Re: [ovs-dev] [PATCHv11 net-next 1/2] openvswitch: Refactor ovs_nla_fill_match().

2014-12-03 Thread Joe Stringer
On 3 December 2014 at 11:37, Pravin Shelar wrote: > On Tue, Dec 2, 2014 at 6:56 PM, Joe Stringer wrote: >> diff --git a/net/openvswitch/datapath.c b/net/openvswitch/datapath.c >> index 332b5a0..b2a3796 100644 >> --- a/net/openvswitch/datapath.c >> +++ b/net/openvswitch/datapath.c >> @@ -462,10 +4

Re: [ovs-dev] [PATCHv11 net-next 1/2] openvswitch: Refactor ovs_nla_fill_match().

2014-12-03 Thread Pravin Shelar
On Tue, Dec 2, 2014 at 6:56 PM, Joe Stringer wrote: > Refactor the ovs_nla_fill_match() function into separate netlink > serialization functions ovs_nla_put_{unmasked_key,masked_key,mask}(). > Modify ovs_nla_put_flow() to handle attribute nesting and expose the > 'is_mask' parameter - all callers

[ovs-dev] [PATCHv11 net-next 1/2] openvswitch: Refactor ovs_nla_fill_match().

2014-12-02 Thread Joe Stringer
Refactor the ovs_nla_fill_match() function into separate netlink serialization functions ovs_nla_put_{unmasked_key,masked_key,mask}(). Modify ovs_nla_put_flow() to handle attribute nesting and expose the 'is_mask' parameter - all callers need to nest the flow, and callers have better knowledge abou