Re: [ovs-dev] [PATCH v9 3/6] Add execute_actions

2013-05-23 Thread Simon Horman
On Thu, May 23, 2013 at 10:58:46AM -0700, Ben Pfaff wrote: > Let's use a better name for the new files, say odp-execute.[ch], and > use an appropriately prefixed name for the function, > e.g. odp_actions_execute(). Thanks, I have renamed the files as odp-execute.[ch], and prefixed the functions wi

Re: [ovs-dev] [PATCH v9 3/6] Add execute_actions

2013-05-23 Thread Ben Pfaff
Let's use a better name for the new files, say odp-execute.[ch], and use an appropriately prefixed name for the function, e.g. odp_actions_execute(). It would also be acceptable to break action-related code out of odp-util.[ch] and put all of it in a new odp-actions.[ch]. Some more comments: On

[ovs-dev] [PATCH v9 3/6] Add execute_actions

2013-05-22 Thread Simon Horman
This moves generic action execution code out of lib/dpif-netedev.c and into a new file, lib/execute-actions.c. This is in preparation for using execute_set_action() in lib/odp-util.c to handle recirculation/ Signed-off-by: Simon Horman --- v9 * As suggested by Jesse Gross - Follow the conventi