Re: [ovs-dev] [PATCH v8] Extend OVS IPFIX exporter to export tunnel headers

2014-08-13 Thread Wenyu Zhang
-Original Message- From: Pravin Shelar [mailto:pshe...@nicira.com] Sent: Thursday, August 14, 2014 8:37 AM To: Wenyu Zhang Cc: Ben Pfaff; Jesse Gross; Romain Lenglet; dev@openvswitch.org Subject: Re: [PATCH v8] Extend OVS IPFIX exporter to export tunnel headers On Wed, Aug 13, 2014 at 5

Re: [ovs-dev] [PATCH v8] Extend OVS IPFIX exporter to export tunnel headers

2014-08-13 Thread Pravin Shelar
On Wed, Aug 13, 2014 at 5:25 PM, Wenyu Zhang wrote: >>> Signed-off-by: Wenyu Zhang >>> Acked-by: Romain Lenglet >> >> This patch renumbers OVS_TUNNEL_KEY_ATTR_OAM and >> OVS_TUNNEL_KEY_ATTR_GENEVE_OPTS. Is that really OK? >> > It is not ok. > There are another fixes to kernel part which I was g

Re: [ovs-dev] [PATCH v8] Extend OVS IPFIX exporter to export tunnel headers

2014-08-13 Thread Wenyu Zhang
>> Signed-off-by: Wenyu Zhang >> Acked-by: Romain Lenglet > > This patch renumbers OVS_TUNNEL_KEY_ATTR_OAM and > OVS_TUNNEL_KEY_ATTR_GENEVE_OPTS. Is that really OK? > It is not ok. There are another fixes to kernel part which I was going to do before pushing this patch to master. Thanks, Prav

Re: [ovs-dev] [PATCH v8] Extend OVS IPFIX exporter to export tunnel headers

2014-08-13 Thread Ben Pfaff
On Fri, Aug 08, 2014 at 04:02:24AM -0700, Wenyu Zhang wrote: > Extend IPFIX exporter to export tunnel headers when both input and output > of the port. > Add three other_config options in IPFIX table: enable-input-sampling, > enable-output-sampling and enable-tunnel-sampling, to control whether > s

Re: [ovs-dev] [PATCH v8] Extend OVS IPFIX exporter to export tunnel headers

2014-08-13 Thread Pravin Shelar
On Wed, Aug 13, 2014 at 10:01 AM, Ben Pfaff wrote: > On Fri, Aug 08, 2014 at 04:02:24AM -0700, Wenyu Zhang wrote: >> Extend IPFIX exporter to export tunnel headers when both input and output >> of the port. >> Add three other_config options in IPFIX table: enable-input-sampling, >> enable-output-s

Re: [ovs-dev] [PATCH v8] Extend OVS IPFIX exporter to export tunnel headers

2014-08-13 Thread Ben Pfaff
On Fri, Aug 08, 2014 at 04:02:24AM -0700, Wenyu Zhang wrote: > Extend IPFIX exporter to export tunnel headers when both input and output > of the port. > Add three other_config options in IPFIX table: enable-input-sampling, > enable-output-sampling and enable-tunnel-sampling, to control whether > s

[ovs-dev] [PATCH v8] Extend OVS IPFIX exporter to export tunnel headers

2014-08-08 Thread Wenyu Zhang
Extend IPFIX exporter to export tunnel headers when both input and output of the port. Add three other_config options in IPFIX table: enable-input-sampling, enable-output-sampling and enable-tunnel-sampling, to control whether sampling tunnel info, on which direction (input or output). Insert sampl

Re: [ovs-dev] [PATCH v8] Extend OVS IPFIX exporter to export tunnel headers

2014-08-08 Thread Wenyu Zhang
Sorry, please ingore it. There is a mistake in the patch, I will resend the patch soon. -Original Message- From: Wenyu Zhang Sent: Friday, August 08, 2014 6:12 PM To: Wenyu Zhang; Romain Lenglet; pshe...@nicira.com; b...@nicira.com; Jesse Gross; dev@openvswitch.org Subject: [PATCH v8] E

[ovs-dev] [PATCH v8] Extend OVS IPFIX exporter to export tunnel headers

2014-08-08 Thread Wenyu Zhang
Extend IPFIX exporter to export tunnel headers when both input and output of the port. Add three other_config options in IPFIX table: enable-input-sampling, enable-output-sampling and enable-tunnel-sampling, to control whether sampling tunnel info, on which direction (input or output). Insert sampl