Re: [ovs-dev] [PATCH v6 00/18] Rapid Spanning Tree Protocol

2014-09-25 Thread Jarno Rajahalme
On Sep 25, 2014, at 7:52 AM, Daniele Venturino wrote: > After some testing, here’s my ack. > > Acked-by: Daniele Venturino Pushed to master, thanks! Jarno diff --git a/ofproto/ofproto-dpif.c b/ofproto/ofproto-dpif.c index d3e527a..d3973e5 100644 --- a/ofproto/ofproto

Re: [ovs-dev] [PATCH v6 00/18] Rapid Spanning Tree Protocol

2014-09-25 Thread Daniele Venturino
After some testing, here’s my ack. Acked-by: Daniele Venturino ha scritto: > > On Sep 19, 2014, at 8:26 AM, Daniele Venturino > wrote: > >> >> Il giorno 11/set/2014, alle ore 19:09, Jarno Rajahalme >> ha scritto: >> >>> >>> On Sep 11, 2014, at 5:49 AM, Daniele Venturino >>> wrote: >>

Re: [ovs-dev] [PATCH v6 00/18] Rapid Spanning Tree Protocol

2014-09-19 Thread Jarno Rajahalme
On Sep 19, 2014, at 8:26 AM, Daniele Venturino wrote: > > Il giorno 11/set/2014, alle ore 19:09, Jarno Rajahalme > ha scritto: > >> >> On Sep 11, 2014, at 5:49 AM, Daniele Venturino >> wrote: >> >>> >>> Il giorno 09/set/2014, alle ore 22:04, Daniele Venturino >>> ha scritto: >>>

Re: [ovs-dev] [PATCH v6 00/18] Rapid Spanning Tree Protocol

2014-09-19 Thread Daniele Venturino
Il giorno 11/set/2014, alle ore 19:09, Jarno Rajahalme ha scritto: > > On Sep 11, 2014, at 5:49 AM, Daniele Venturino > wrote: > >> >> Il giorno 09/set/2014, alle ore 22:04, Daniele Venturino >> ha scritto: >> >>> >>> Il giorno 09/set/2014, alle ore 20:07, Jarno Rajahalme >>> ha scri

Re: [ovs-dev] [PATCH v6 00/18] Rapid Spanning Tree Protocol

2014-09-11 Thread Jarno Rajahalme
On Sep 11, 2014, at 5:49 AM, Daniele Venturino wrote: > > Il giorno 09/set/2014, alle ore 22:04, Daniele Venturino > ha scritto: > >> >> Il giorno 09/set/2014, alle ore 20:07, Jarno Rajahalme >> ha scritto: >> >>> >>> On Sep 9, 2014, at 3:53 AM, Daniele Venturino >>> wrote: >>>

Re: [ovs-dev] [PATCH v6 00/18] Rapid Spanning Tree Protocol

2014-09-11 Thread Daniele Venturino
Il giorno 09/set/2014, alle ore 22:04, Daniele Venturino ha scritto: > > Il giorno 09/set/2014, alle ore 20:07, Jarno Rajahalme > ha scritto: > >> >> On Sep 9, 2014, at 3:53 AM, Daniele Venturino >> wrote: >> >>> >>> Thanks for the review! >>> It would be nice to have an Acked-by from

Re: [ovs-dev] [PATCH v6 00/18] Rapid Spanning Tree Protocol

2014-09-09 Thread Daniele Venturino
Il giorno 09/set/2014, alle ore 20:07, Jarno Rajahalme ha scritto: > > On Sep 9, 2014, at 3:53 AM, Daniele Venturino > wrote: > >> >> Thanks for the review! >> It would be nice to have an Acked-by from you to the series. However, I plan >> to squash trivial CodingStyle fixes in before pus

Re: [ovs-dev] [PATCH v6 00/18] Rapid Spanning Tree Protocol

2014-09-09 Thread Jarno Rajahalme
On Sep 9, 2014, at 3:53 AM, Daniele Venturino wrote: > > Thanks for the review! > It would be nice to have an Acked-by from you to the series. However, I plan > to squash trivial CodingStyle fixes in before pushing the series to master. > Also, I’ll add a News item stating that experimental

Re: [ovs-dev] [PATCH v6 00/18] Rapid Spanning Tree Protocol

2014-09-09 Thread Daniele Venturino
> > > Thanks for the review! > It would be nice to have an Acked-by from you to the series. However, I > plan to squash trivial CodingStyle fixes in before pushing the series to > master. Also, I’ll add a News item stating that experimental RSTP is added, > and more compliance and interoperability

Re: [ovs-dev] [PATCH v6 00/18] Rapid Spanning Tree Protocol

2014-09-08 Thread Jarno Rajahalme
Thanks for the review! It would be nice to have an Acked-by from you to the series. However, I plan to squash trivial CodingStyle fixes in before pushing the series to master. Also, I’ll add a News item stating that experimental RSTP is added, and more compliance and interoperability testing is

Re: [ovs-dev] [PATCH v6 00/18] Rapid Spanning Tree Protocol

2014-09-03 Thread Daniele Venturino
I looked and applied the patches. They’re good to me, I just have some notes on patch 13/18 and 16/18. @@ -108,9 +121,9 @@ process_received_bpdu(struct rstp_port *p, const void > *bpdu, size_t bpdu_size) > memcpy(&p->received_bpdu_buffer, bpdu, sizeof(struct rstp_bpdu)); > rstp

[ovs-dev] [PATCH v6 00/18] Rapid Spanning Tree Protocol

2014-08-20 Thread Jarno Rajahalme
I took my time starting the review, so I decided address issues as I see them rather than just comment on them. The first patch of this series is a minimally rebased version of the v5 sent on ovs-dev on June 12th, 2014. Rest of the series is my proposal for fixes and enhancements. I could have r