Re: [ovs-dev] [PATCH v6] gre: Restructure tunneling.

2013-06-21 Thread Jesse Gross
Thanks, it looks like a real issue to me. I sent out a patch that should fix it. On Fri, Jun 21, 2013 at 1:19 AM, Joe Stringer wrote: > I get a warning in gso.c after this patch: > > datapath/linux/gso.c: In function ‘rpl_ip_local_out’: > datapath/linux/gso.c:134:174: warning: ‘id’ may be used un

Re: [ovs-dev] [PATCH v6] gre: Restructure tunneling.

2013-06-21 Thread Joe Stringer
I get a warning in gso.c after this patch: datapath/linux/gso.c: In function ‘rpl_ip_local_out’: datapath/linux/gso.c:134:174: warning: ‘id’ may be used uninitialized in this function [-Wuninitialized] Could you take a look at this? On Fri, Jun 21, 2013 at 3:14 PM, Pravin Shelar wrote: > On T

Re: [ovs-dev] [PATCH v6] gre: Restructure tunneling.

2013-06-20 Thread Pravin Shelar
On Thu, Jun 20, 2013 at 5:50 PM, Jesse Gross wrote: > On Thu, Jun 20, 2013 at 5:19 PM, Pravin B Shelar wrote: >> diff --git a/datapath/linux/compat/skbuff-openvswitch.c >> b/datapath/linux/compat/skbuff-openvswitch.c >> index ef43ba9..720bc18 100644 >> --- a/datapath/linux/compat/skbuff-openvswi

Re: [ovs-dev] [PATCH v6] gre: Restructure tunneling.

2013-06-20 Thread Jesse Gross
On Thu, Jun 20, 2013 at 5:19 PM, Pravin B Shelar wrote: > diff --git a/datapath/linux/compat/skbuff-openvswitch.c > b/datapath/linux/compat/skbuff-openvswitch.c > index ef43ba9..720bc18 100644 > --- a/datapath/linux/compat/skbuff-openvswitch.c > +++ b/datapath/linux/compat/skbuff-openvswitch.c >

[ovs-dev] [PATCH v6] gre: Restructure tunneling.

2013-06-20 Thread Pravin B Shelar
Following patch restructures ovs tunneling and gre vport implementation to make ovs tunneling more in sync with upstream kernel tunneling. Doing this tunneling code is simplified as most of protocol processing on send and recv is pushed to kernel tunneling. For external ovs module the code is mov