Re: [ovs-dev] [PATCH v5 2/2] datapath: Per NUMA node flow stats.

2014-02-10 Thread Jarno Rajahalme
On Feb 10, 2014, at 3:28 PM, Jesse Gross wrote: > On Mon, Feb 10, 2014 at 11:15 AM, Pravin Shelar wrote: >> On Thu, Feb 6, 2014 at 3:13 PM, Jarno Rajahalme >> wrote: >>> @@ -80,96 +76,126 @@ void ovs_flow_stats_update(struct sw_flow *flow, >>> struct sk_buff *skb) >>>tcp_flag

Re: [ovs-dev] [PATCH v5 2/2] datapath: Per NUMA node flow stats.

2014-02-10 Thread Jarno Rajahalme
On Feb 10, 2014, at 3:21 PM, Jesse Gross wrote: > On Mon, Feb 10, 2014 at 11:31 AM, Jarno Rajahalme > wrote: >> On Feb 8, 2014, at 7:01 PM, Jesse Gross wrote: >>> On Thu, Feb 6, 2014 at 3:13 PM, Jarno Rajahalme >>> wrote: diff --git a/datapath/flow.h b/datapath/flow.h index eafcfd

Re: [ovs-dev] [PATCH v5 2/2] datapath: Per NUMA node flow stats.

2014-02-10 Thread Jesse Gross
On Mon, Feb 10, 2014 at 11:15 AM, Pravin Shelar wrote: > On Thu, Feb 6, 2014 at 3:13 PM, Jarno Rajahalme wrote: >> @@ -80,96 +76,126 @@ void ovs_flow_stats_update(struct sw_flow *flow, struct >> sk_buff *skb) >> tcp_flags = TCP_FLAGS_BE16(tcp_hdr(skb)); >> } >> >> -

Re: [ovs-dev] [PATCH v5 2/2] datapath: Per NUMA node flow stats.

2014-02-10 Thread Jesse Gross
On Mon, Feb 10, 2014 at 11:31 AM, Jarno Rajahalme wrote: > On Feb 8, 2014, at 7:01 PM, Jesse Gross wrote: >> On Thu, Feb 6, 2014 at 3:13 PM, Jarno Rajahalme >> wrote: >>> diff --git a/datapath/flow.h b/datapath/flow.h >>> index eafcfd8..f6cce35 100644 >>> --- a/datapath/flow.h >>> +++ b/datapat

Re: [ovs-dev] [PATCH v5 2/2] datapath: Per NUMA node flow stats.

2014-02-10 Thread Jarno Rajahalme
On Feb 8, 2014, at 7:01 PM, Jesse Gross wrote: > On Thu, Feb 6, 2014 at 3:13 PM, Jarno Rajahalme wrote: >> diff --git a/datapath/flow.c b/datapath/flow.c >> index abe6789..e86034e 100644 >> --- a/datapath/flow.c >> +++ b/datapath/flow.c >> @@ -80,96 +76,126 @@ void ovs_flow_stats_update(struct

Re: [ovs-dev] [PATCH v5 2/2] datapath: Per NUMA node flow stats.

2014-02-10 Thread Pravin Shelar
On Thu, Feb 6, 2014 at 3:13 PM, Jarno Rajahalme wrote: > Keep kernel flow stats for each NUMA node rather than each (logical) > CPU. This avoids using the per-CPU allocator and removes most of the > > diff --git a/datapath/flow.c b/datapath/flow.c > index abe6789..e86034e 100644 > --- a/d

Re: [ovs-dev] [PATCH v5 2/2] datapath: Per NUMA node flow stats.

2014-02-08 Thread Jesse Gross
On Thu, Feb 6, 2014 at 3:13 PM, Jarno Rajahalme wrote: > diff --git a/datapath/flow.c b/datapath/flow.c > index abe6789..e86034e 100644 > --- a/datapath/flow.c > +++ b/datapath/flow.c > @@ -80,96 +76,126 @@ void ovs_flow_stats_update(struct sw_flow *flow, struct > sk_buff *skb) >

Re: [ovs-dev] [PATCH v5 2/2] datapath: Per NUMA node flow stats.

2014-02-06 Thread Jarno Rajahalme
> On Feb 6, 2014, at 6:36 PM, Jesse Gross wrote: > >> On Thu, Feb 6, 2014 at 4:09 PM, Pravin Shelar wrote: >>> On Thu, Feb 6, 2014 at 3:13 PM, Jarno Rajahalme >>> wrote: >>>Keep kernel flow stats for each NUMA node rather than each (logical) >>>CPU. This avoids using the per-CPU allo

Re: [ovs-dev] [PATCH v5 2/2] datapath: Per NUMA node flow stats.

2014-02-06 Thread Jesse Gross
On Thu, Feb 6, 2014 at 4:09 PM, Pravin Shelar wrote: > On Thu, Feb 6, 2014 at 3:13 PM, Jarno Rajahalme wrote: >> Keep kernel flow stats for each NUMA node rather than each (logical) >> CPU. This avoids using the per-CPU allocator and removes most of the >> kernel-side OVS locking ove

Re: [ovs-dev] [PATCH v5 2/2] datapath: Per NUMA node flow stats.

2014-02-06 Thread Pravin Shelar
On Thu, Feb 6, 2014 at 3:13 PM, Jarno Rajahalme wrote: > Keep kernel flow stats for each NUMA node rather than each (logical) > CPU. This avoids using the per-CPU allocator and removes most of the > kernel-side OVS locking overhead otherwise on the top of perf reports > and allows

[ovs-dev] [PATCH v5 2/2] datapath: Per NUMA node flow stats.

2014-02-06 Thread Jarno Rajahalme
Keep kernel flow stats for each NUMA node rather than each (logical) CPU. This avoids using the per-CPU allocator and removes most of the kernel-side OVS locking overhead otherwise on the top of perf reports and allows OVS to scale better with higher number of threads. With 9