Re: [ovs-dev] [PATCH v5 1/9] datapath: Build flow cmd netlink reply only if needed.

2014-03-29 Thread Jarno Rajahalme
Thanks for the review, pushed to master, Jarno On Mar 28, 2014, at 1:25 PM, Pravin Shelar wrote: > On Tue, Mar 25, 2014 at 2:35 PM, Jarno Rajahalme > wrote: >> Use netlink_has_listeners() and NLM_F_ECHO flag to determine if a >> reply is needed or not for OVS_FLOW_CMD_NEW, OVS_FLOW_CMD_SET,

Re: [ovs-dev] [PATCH v5 1/9] datapath: Build flow cmd netlink reply only if needed.

2014-03-28 Thread Pravin Shelar
On Tue, Mar 25, 2014 at 2:35 PM, Jarno Rajahalme wrote: > Use netlink_has_listeners() and NLM_F_ECHO flag to determine if a > reply is needed or not for OVS_FLOW_CMD_NEW, OVS_FLOW_CMD_SET, or > OVS_FLOW_CMD_DEL. Currently, OVS userspace does not request a reply > for OVS_FLOW_CMD_NEW, but usually

[ovs-dev] [PATCH v5 1/9] datapath: Build flow cmd netlink reply only if needed.

2014-03-25 Thread Jarno Rajahalme
Use netlink_has_listeners() and NLM_F_ECHO flag to determine if a reply is needed or not for OVS_FLOW_CMD_NEW, OVS_FLOW_CMD_SET, or OVS_FLOW_CMD_DEL. Currently, OVS userspace does not request a reply for OVS_FLOW_CMD_NEW, but usually does for OVS_FLOW_CMD_DEL, as stats may have changed. Signed-of