Re: [ovs-dev] [PATCH v5 08/13] lib/odp: Use masked set actions.

2014-09-09 Thread Jarno Rajahalme
I’ll try to make a habit of compiling with C=1 before posting… Thanks for the review, fixed and pushed, Jarno On Sep 9, 2014, at 12:32 PM, Ben Pfaff wrote: > On Fri, Sep 05, 2014 at 04:05:15PM -0700, Jarno Rajahalme wrote: >> Signed-off-by: Jarno Rajahalme >> --- >> v5: Using pattern with l

Re: [ovs-dev] [PATCH v5 08/13] lib/odp: Use masked set actions.

2014-09-09 Thread Ben Pfaff
On Fri, Sep 05, 2014 at 04:05:15PM -0700, Jarno Rajahalme wrote: > Signed-off-by: Jarno Rajahalme > --- > v5: Using pattern with less code duplication suggested by Ben. odp_mask_is_exact() treats the unused bits in tun_mask->flags differently from the unused bits in ipv6_mask->ipv6_label. I gues

[ovs-dev] [PATCH v5 08/13] lib/odp: Use masked set actions.

2014-09-05 Thread Jarno Rajahalme
Signed-off-by: Jarno Rajahalme --- v5: Using pattern with less code duplication suggested by Ben. lib/odp-util.c | 487 ++ lib/odp-util.h |5 +- ofproto/ofproto-dpif-xlate.c | 15 +- tests/ofproto-dpif.at| 66 ++