Jesse,
I’ll send a new patch series soon, but here are the fixes to the comments below
for your viewing pleasure:
Jarno
diff --git a/datapath/actions.c b/datapath/actions.c
index 0cb7c9e..243b672 100644
--- a/datapath/actions.c
+++ b/datapath/actions.c
@@ -510,7 +510,7 @@ static int set_ipv4(
On Sep 5, 2014, at 2:26 PM, Jarno Rajahalme wrote:
>
> On Sep 5, 2014, at 2:12 PM, Jarno Rajahalme wrote:
>
case OVS_KEY_ATTR_IPV4:
>>> [...]
- if (ipv4_key->ipv4_frag != flow_key->ip.frag)
- return -EINVAL;
+
On Sep 5, 2014, at 2:12 PM, Jarno Rajahalme wrote:
>>>
>>> case OVS_KEY_ATTR_IPV4:
>> [...]
>>> - if (ipv4_key->ipv4_frag != flow_key->ip.frag)
>>> - return -EINVAL;
>>> + /* Non-writeable fields. */
>>> + if
On Aug 11, 2014, at 5:39 PM, Jesse Gross wrote:
> On Mon, Aug 11, 2014 at 9:15 AM, Jarno Rajahalme
> wrote:
>> Masked set action allows more megaflow wildcarding. Masked set action
>> is now supported for all writeable key types, except for the tunnel
>> key.
>>
>> The set tunnel action is a
On Mon, Aug 11, 2014 at 09:15:01AM -0700, Jarno Rajahalme wrote:
> Masked set action allows more megaflow wildcarding. Masked set action
> is now supported for all writeable key types, except for the tunnel
> key.
>
> The set tunnel action is an exception as any input tunnel info is
> cleared bef
On Mon, Aug 11, 2014 at 9:15 AM, Jarno Rajahalme wrote:
> Masked set action allows more megaflow wildcarding. Masked set action
> is now supported for all writeable key types, except for the tunnel
> key.
>
> The set tunnel action is an exception as any input tunnel info is
> cleared before actio
Masked set action allows more megaflow wildcarding. Masked set action
is now supported for all writeable key types, except for the tunnel
key.
The set tunnel action is an exception as any input tunnel info is
cleared before action processing starts, so there is no tunnel info to
mask.
The kernel
