Re: [ovs-dev] [PATCH v4 3/4] lib/odp: Use masked set actions.

2014-09-05 Thread Jarno Rajahalme
On Aug 12, 2014, at 3:45 PM, Ben Pfaff wrote: > On Mon, Aug 11, 2014 at 09:15:00AM -0700, Jarno Rajahalme wrote: >> Signed-off-by: Jarno Rajahalme > > The amount of redundancy in the code at this point is starting to give > me a headache. How about a pattern like this (provided as an > increm

Re: [ovs-dev] [PATCH v4 3/4] lib/odp: Use masked set actions.

2014-08-12 Thread Ben Pfaff
On Mon, Aug 11, 2014 at 09:15:00AM -0700, Jarno Rajahalme wrote: > Signed-off-by: Jarno Rajahalme The amount of redundancy in the code at this point is starting to give me a headache. How about a pattern like this (provided as an incremental)? diff --git a/lib/odp-util.c b/lib/odp-util.c index

[ovs-dev] [PATCH v4 3/4] lib/odp: Use masked set actions.

2014-08-11 Thread Jarno Rajahalme
Signed-off-by: Jarno Rajahalme --- lib/odp-util.c | 368 ++ lib/odp-util.h |5 +- ofproto/ofproto-dpif-xlate.c | 15 +- tests/ofproto-dpif.at| 62 --- tests/tunnel.at |8 +- 5 files changed,