Re: [ovs-dev] [PATCH v4 3/3] datapath: add layer 3 flow/port support

2014-11-03 Thread Lori Jakab
On 11/1/14 1:03 AM, Jesse Gross wrote: On Thu, Oct 9, 2014 at 3:34 AM, Lori Jakab wrote: On 9/12/14 12:26 AM, Jesse Gross wrote: On Mon, Sep 8, 2014 at 5:43 AM, Lori Jakab wrote: --- a/datapath/flow_netlink.c +++ b/datapath/flow_netlink.c @@ -1831,6 +1831,8 @@ static int __ovs_nla_copy_actio

Re: [ovs-dev] [PATCH v4 3/3] datapath: add layer 3 flow/port support

2014-10-31 Thread Jesse Gross
On Thu, Oct 9, 2014 at 3:34 AM, Lori Jakab wrote: > On 9/12/14 12:26 AM, Jesse Gross wrote: >> On Mon, Sep 8, 2014 at 5:43 AM, Lori Jakab wrote: >>> --- a/datapath/flow_netlink.c >>> +++ b/datapath/flow_netlink.c >>> @@ -1831,6 +1831,8 @@ static int __ovs_nla_copy_actions(const struct >>> nlattr

Re: [ovs-dev] [PATCH v4 3/3] datapath: add layer 3 flow/port support

2014-10-09 Thread Lori Jakab
Hi Jesse, Sorry for the long delay in replying to the thread, was busy with OpenDaylight. See inline below: On 9/12/14 12:26 AM, Jesse Gross wrote: On Mon, Sep 8, 2014 at 5:43 AM, Lori Jakab wrote: On 8/25/14 3:33 AM, Jesse Gross wrote: On Thu, Aug 21, 2014 at 12:24 PM, Lori Jakab wrote:

Re: [ovs-dev] [PATCH v4 3/3] datapath: add layer 3 flow/port support

2014-09-11 Thread Jesse Gross
On Mon, Sep 8, 2014 at 5:43 AM, Lori Jakab wrote: > On 8/25/14 3:33 AM, Jesse Gross wrote: >> >> On Thu, Aug 21, 2014 at 12:24 PM, Lori Jakab wrote: >>> >>> On 8/6/14 4:37 AM, Jesse Gross wrote: Besides the fact that it would be nice to unify things, I'm not sure that it is actuall

Re: [ovs-dev] [PATCH v4 3/3] datapath: add layer 3 flow/port support

2014-09-08 Thread Lori Jakab
On 8/25/14 3:33 AM, Jesse Gross wrote: On Thu, Aug 21, 2014 at 12:24 PM, Lori Jakab wrote: On 8/6/14 4:37 AM, Jesse Gross wrote: Besides the fact that it would be nice to unify things, I'm not sure that it is actually correct to pull off VLAN, MPLS, etc. tags that we don't understand. Presumab

Re: [ovs-dev] [PATCH v4 3/3] datapath: add layer 3 flow/port support

2014-08-24 Thread Jesse Gross
On Thu, Aug 21, 2014 at 12:24 PM, Lori Jakab wrote: > On 8/6/14 4:37 AM, Jesse Gross wrote: >> Besides the fact that it would be nice to unify things, I'm not sure >> that it is actually correct to pull off VLAN, MPLS, etc. tags that we >> don't understand. Presumably, these are being used to crea

Re: [ovs-dev] [PATCH v4 3/3] datapath: add layer 3 flow/port support

2014-08-21 Thread Lori Jakab
On 8/2/14 4:11 AM, Jesse Gross wrote: On Fri, Aug 1, 2014 at 3:19 PM, Lori Jakab wrote: On 8/1/14, 3:25 AM, Jesse Gross wrote: On Thu, Jul 31, 2014 at 5:45 AM, Lori Jakab wrote: On 7/31/14, 10:09 AM, Jesse Gross wrote: On Fri, Jun 27, 2014 at 6:21 AM, Lorand Jakab wrote: diff --git a/dat

Re: [ovs-dev] [PATCH v4 3/3] datapath: add layer 3 flow/port support

2014-08-21 Thread Lori Jakab
On 8/6/14 4:37 AM, Jesse Gross wrote: On 8/2/14, 4:11 AM, Jesse Gross wrote: On Fri, Aug 1, 2014 at 3:19 PM, Lori Jakab wrote: On 8/1/14, 3:25 AM, Jesse Gross wrote: On Thu, Jul 31, 2014 at 5:45 AM, Lori Jakab wrote: On 7/31/14, 10:09 AM, Jesse Gross wrote: Going further, what happens if p

Re: [ovs-dev] [PATCH v4 3/3] datapath: add layer 3 flow/port support

2014-08-05 Thread Jesse Gross
On Tue, Aug 5, 2014 at 1:45 PM, Lori Jakab wrote: > Hi Jesse, > > I'll be on vacation starting tomorrow, it looks like this won't be merged > for at least another two weeks. Have a nice vacation. Sorry that we couldn't get this in before you leave. > On 8/2/14, 4:11 AM, Jesse Gross wrote: >> On

Re: [ovs-dev] [PATCH v4 3/3] datapath: add layer 3 flow/port support

2014-08-05 Thread Lori Jakab
Hi Jesse, I'll be on vacation starting tomorrow, it looks like this won't be merged for at least another two weeks. Replies on discussion points in-line below: On 8/2/14, 4:11 AM, Jesse Gross wrote: On Fri, Aug 1, 2014 at 3:19 PM, Lori Jakab wrote: On 8/1/14, 3:25 AM, Jesse Gross wrote: O

Re: [ovs-dev] [PATCH v4 3/3] datapath: add layer 3 flow/port support

2014-08-01 Thread Jesse Gross
On Fri, Aug 1, 2014 at 3:19 PM, Lori Jakab wrote: > On 8/1/14, 3:25 AM, Jesse Gross wrote: >> >> On Thu, Jul 31, 2014 at 5:45 AM, Lori Jakab wrote: >>> >>> On 7/31/14, 10:09 AM, Jesse Gross wrote: On Fri, Jun 27, 2014 at 6:21 AM, Lorand Jakab wrote: > > diff --git a/datapath/ac

Re: [ovs-dev] [PATCH v4 3/3] datapath: add layer 3 flow/port support

2014-08-01 Thread Lori Jakab
On 8/1/14, 3:25 AM, Jesse Gross wrote: On Thu, Jul 31, 2014 at 5:45 AM, Lori Jakab wrote: On 7/31/14, 10:09 AM, Jesse Gross wrote: On Fri, Jun 27, 2014 at 6:21 AM, Lorand Jakab wrote: diff --git a/datapath/actions.c b/datapath/actions.c index cb26ad5..20c66f5 100644 --- a/datapath/actions.c

Re: [ovs-dev] [PATCH v4 3/3] datapath: add layer 3 flow/port support

2014-07-31 Thread Jesse Gross
On Thu, Jul 31, 2014 at 5:45 AM, Lori Jakab wrote: > On 7/31/14, 10:09 AM, Jesse Gross wrote: >> On Fri, Jun 27, 2014 at 6:21 AM, Lorand Jakab wrote: >>> diff --git a/datapath/actions.c b/datapath/actions.c >>> index cb26ad5..20c66f5 100644 >>> --- a/datapath/actions.c >>> +++ b/datapath/actions.

Re: [ovs-dev] [PATCH v4 3/3] datapath: add layer 3 flow/port support

2014-07-31 Thread Lori Jakab
On 7/31/14, 10:09 AM, Jesse Gross wrote: On Fri, Jun 27, 2014 at 6:21 AM, Lorand Jakab wrote: Implementation of the pop_eth and push_eth actions in the kernel, and layer 3 flow support. Signed-off-by: Lorand Jakab Thank you for your patience on this. Thanks for finding the time to review i

Re: [ovs-dev] [PATCH v4 3/3] datapath: add layer 3 flow/port support

2014-07-31 Thread Jesse Gross
On Fri, Jun 27, 2014 at 6:21 AM, Lorand Jakab wrote: > Implementation of the pop_eth and push_eth actions in the kernel, and > layer 3 flow support. > > Signed-off-by: Lorand Jakab Thank you for your patience on this. > diff --git a/datapath/actions.c b/datapath/actions.c > index cb26ad5..20c66

[ovs-dev] [PATCH v4 3/3] datapath: add layer 3 flow/port support

2014-06-27 Thread Lorand Jakab
Implementation of the pop_eth and push_eth actions in the kernel, and layer 3 flow support. Signed-off-by: Lorand Jakab --- datapath/actions.c| 35 + datapath/datapath.h | 1 + datapath/flow.c | 47 datapath/fl