Re: [ovs-dev] [PATCH v4 2/2] dpif-netdev: Exact match cache

2014-08-29 Thread Daniele Di Proietto
Thanks for the suggestions I applied all of them except (as discussed offline): - some style fixes (CodingStyle shows that operator && and || should be after a newline) - the removal of dp_netdev_queu_batches() Œmax_batches¹ parameter. Perhaps we can remove it in the future, but now it is neede

Re: [ovs-dev] [PATCH v4 2/2] dpif-netdev: Exact match cache

2014-08-29 Thread Pravin Shelar
On Tue, Aug 19, 2014 at 5:11 PM, Daniele Di Proietto wrote: > Since lookups in the classifier can be pretty expensive, we introduce this > (thread local) cache which simply compares the miniflows of the packets > > Signed-off-by: Daniele Di Proietto I have few suggestions in attached patch, can

Re: [ovs-dev] [PATCH v4 2/2] dpif-netdev: Exact match cache

2014-08-20 Thread Jarno Rajahalme
> On Aug 19, 2014, at 5:11 PM, Daniele Di Proietto > wrote: (Snip) > +static inline size_t > +emc_processing(struct dp_netdev *dp, struct emc_cache *flow_cache, > + struct dpif_packet **packets, size_t cnt, > + struct pkt_metadata *md, struct netdev_flow_key *keys

[ovs-dev] [PATCH v4 2/2] dpif-netdev: Exact match cache

2014-08-19 Thread Daniele Di Proietto
Since lookups in the classifier can be pretty expensive, we introduce this (thread local) cache which simply compares the miniflows of the packets Signed-off-by: Daniele Di Proietto --- lib/dpif-netdev.c | 431 +- 1 file changed, 358 insertions