On Mon, Oct 14, 2013 at 8:12 AM, Ben Pfaff wrote:
> On Wed, Oct 09, 2013 at 02:57:55PM -0700, Jarno Rajahalme wrote:
> >
> > On Oct 8, 2013, at 5:13 PM, Ben Pfaff wrote:
> >
> > > The issue is not the minimum Ethernet frame size but the minimum IP
> > > fragment size. IP fragments are 8-byte al
On Wed, Oct 09, 2013 at 02:57:55PM -0700, Jarno Rajahalme wrote:
>
> On Oct 8, 2013, at 5:13 PM, Ben Pfaff wrote:
>
> > The issue is not the minimum Ethernet frame size but the minimum IP
> > fragment size. IP fragments are 8-byte aligned and a multiple of 8
> > bytes in length. One way to imp
On Oct 8, 2013, at 5:13 PM, Ben Pfaff wrote:
> The issue is not the minimum Ethernet frame size but the minimum IP
> fragment size. IP fragments are 8-byte aligned and a multiple of 8
> bytes in length. One way to implement a simple firewall that handles
> fragments properly is to pass all "la
On Tue, Oct 08, 2013 at 04:48:04PM -0700, Jarno Rajahalme wrote:
> On Oct 8, 2013, at 2:56 PM, b...@nicira.com wrote:
> > Since this adds the 'zeros' field back to struct flow, it needs to add
> > code to actually zero that field in a few places. Take a look at the
> > corresponding code that was
Ben,
Thank you for a thorough review, see some comments below:
On Oct 8, 2013, at 2:56 PM, b...@nicira.com wrote:
> On Tue, Oct 08, 2013 at 01:56:55PM -0700, Jarno Rajahalme wrote:
>>tcp_flags=flags/mask
>>Bitwise match on TCP flags. The flags and mask are 16-bit num???
>>b
On Tue, Oct 08, 2013 at 01:56:55PM -0700, Jarno Rajahalme wrote:
> tcp_flags=flags/mask
> Bitwise match on TCP flags. The flags and mask are 16-bit num???
> bers written in decimal or in hexadecimal prefixed by 0x. Each
> 1-bit in mask requires that the correspondi
tcp_flags=flags/mask
Bitwise match on TCP flags. The flags and mask are 16-bit num‐
bers written in decimal or in hexadecimal prefixed by 0x. Each
1-bit in mask requires that the corresponding bit in port must
match. Each 0-bit in mask causes the correspon
