Re: [ovs-dev] [PATCH v4 1/6] datapath-windows: Added recirculation support.

2016-03-10 Thread Ben Pfaff
On Thu, Mar 10, 2016 at 12:32:02PM +, Alin Serdean wrote: > I just updated the patch with the comments. I looked over the whole patch > yesterday and indeed we should pass the source port and search for it when we > are queuing packets to the userspace. > > Also the key and layers should be

Re: [ovs-dev] [PATCH v4 1/6] datapath-windows: Added recirculation support.

2016-03-10 Thread Alin Serdean
h and resend it. Do you think I should respin the rest of the patches also? Thanks, Alin. > -Mesaj original- > De la: Sairam Venugopal [mailto:vsai...@vmware.com] > Trimis: Thursday, March 10, 2016 1:16 AM > Către: Alin Serdean ; > dev@openvswitch.org > Subiect: Re:

Re: [ovs-dev] [PATCH v4 1/6] datapath-windows: Added recirculation support.

2016-03-09 Thread Sairam Venugopal
Hi Alin/Sorin, The OvsDoRecircFlowLookupOutput function currently assumes that the srcVport is always the Internal VPort. It also does not distinguish between Receive vs Transmit in the OvsCreateAndAddPackets call. Shouldn¹t the source VPORT point to the actual source VPORT instead of the Interna

[ovs-dev] [PATCH v4 1/6] datapath-windows: Added recirculation support.

2016-03-07 Thread Alin Serdean
Recirculation support for the OVS extension. Tested using PING and iperf with Driver Verifier enabled. Signed-off-by: Sorin Vinturis Co-authored-by: Alin Gabriel Serdean Reported-by: Sorin Vinturis Reported-at: https://github.com/openvswitch/ovs-issues/issues/104 --- v2: Initialize flow key be