Re: [ovs-dev] [PATCH v4 1/4] lib: Add CRC32C Implementation

2013-08-12 Thread Joe Stringer
Thanks, didn't know about that. I'll use that link instead. On Mon, Aug 12, 2013 at 11:08 PM, Ed Maste wrote: > On 30 July 2013 20:31, Joe Stringer wrote: > > This implementation was derived from FreeBSD: > > http://code.google.com/p/freebsd-head/source/browse/sys/libkern/crc32.c > > The canon

Re: [ovs-dev] [PATCH v4 1/4] lib: Add CRC32C Implementation

2013-08-12 Thread Ed Maste
On 30 July 2013 20:31, Joe Stringer wrote: > This implementation was derived from FreeBSD: > http://code.google.com/p/freebsd-head/source/browse/sys/libkern/crc32.c The canonical FreeBSD web repo location for this file would be: http://svnweb.freebsd.org/base/head/sys/libkern/crc32.c (It doesn't

Re: [ovs-dev] [PATCH v4 1/4] lib: Add CRC32C Implementation

2013-08-11 Thread Ben Pfaff
On Sun, Aug 11, 2013 at 08:41:41PM +0900, Joe Stringer wrote: > On Sat, Aug 10, 2013 at 5:09 AM, Ben Pfaff wrote: > > > On Wed, Jul 31, 2013 at 09:31:55AM +0900, Joe Stringer wrote: > > > +ovs_be32 > > > +crc32c(const uint8_t *data, size_t size) > > > +{ > > > +uint32_t crc = 0xL; > >

Re: [ovs-dev] [PATCH v4 1/4] lib: Add CRC32C Implementation

2013-08-11 Thread Joe Stringer
On Sat, Aug 10, 2013 at 5:09 AM, Ben Pfaff wrote: > On Wed, Jul 31, 2013 at 09:31:55AM +0900, Joe Stringer wrote: > > +ovs_be32 > > +crc32c(const uint8_t *data, size_t size) > > +{ > > +uint32_t crc = 0xL; > > + > > +while (size--) { > > +crc = crc32Table[(crc ^ *data++) &

Re: [ovs-dev] [PATCH v4 1/4] lib: Add CRC32C Implementation

2013-08-09 Thread Ben Pfaff
On Wed, Jul 31, 2013 at 09:31:55AM +0900, Joe Stringer wrote: > +ovs_be32 > +crc32c(const uint8_t *data, size_t size) > +{ > +uint32_t crc = 0xL; > + > +while (size--) { > +crc = crc32Table[(crc ^ *data++) & 0xff] ^ (crc >> 8); > +} > + > +/* The result of this CRC c

[ovs-dev] [PATCH v4 1/4] lib: Add CRC32C Implementation

2013-07-30 Thread Joe Stringer
This implementation was derived from FreeBSD: http://code.google.com/p/freebsd-head/source/browse/sys/libkern/crc32.c Reviewed-by: Simon Horman Signed-off-by: Joe Stringer --- v4: Fold in debian license modification Suppress checksum test sparse warning v3: Rebase Return crc32c checksum