On Aug 26, 2014, at 1:01 AM, Thomas Graf wrote:
> On 08/25/14 at 08:10pm, Jesse Gross wrote:
>> On Mon, Aug 25, 2014 at 7:19 PM, Jarno Rajahalme
>> wrote:
>>> instead of:
>>>
>>> set(ipv4(src=35.8.2.41/0.0.0.0,dst=172.16.0.20/0.0.0.0,proto=6/0xff,tos=0x80/0,ttl=128/0,frag=no/0))
>>>
>>> we c
On 08/25/14 at 08:10pm, Jesse Gross wrote:
> On Mon, Aug 25, 2014 at 7:19 PM, Jarno Rajahalme
> wrote:
> > instead of:
> >
> > set(ipv4(src=35.8.2.41/0.0.0.0,dst=172.16.0.20/0.0.0.0,proto=6/0xff,tos=0x80/0,ttl=128/0,frag=no/0))
> >
> > we could have:
> >
> > set(ipv4(proto=6))
>
> Yes, that's wh
On Mon, Aug 25, 2014 at 7:19 PM, Jarno Rajahalme wrote:
>
> On Aug 11, 2014, at 3:46 PM, Jesse Gross wrote:
>
>> On Mon, Aug 11, 2014 at 9:14 AM, Jarno Rajahalme
>> wrote:
>>> diff --git a/tests/odp.at b/tests/odp.at
>>> index e725f70..58e3ff1 100644
>>> --- a/tests/odp.at
>>> +++ b/tests/odp.a
On Aug 11, 2014, at 3:46 PM, Jesse Gross wrote:
> On Mon, Aug 11, 2014 at 9:14 AM, Jarno Rajahalme
> wrote:
>> diff --git a/tests/odp.at b/tests/odp.at
>> index e725f70..58e3ff1 100644
>> --- a/tests/odp.at
>> +++ b/tests/odp.at
> +set(ipv4(src=35.8.2.41/255.255.255.255,dst=172.16.0.20/255.255
On Mon, Aug 25, 2014 at 10:44:12AM -0700, Jarno Rajahalme wrote:
> Btw, is there an Emacs setting that I could use to indent function
> calls like this by pressing the tab-key? Mine wants the parameters to
> be indented after the opening parenthesis.
I'll respond to the review bits later (I'm at V
On Aug 12, 2014, at 2:44 PM, Ben Pfaff wrote:
> On Mon, Aug 11, 2014 at 09:14:58AM -0700, Jarno Rajahalme wrote:
>> Add a new action type OVS_ACTION_ATTR_SET_MASKED, and support for
>> parsing, printing, and committing them.
>>
>> Masked set actions add a mask, immediately following the netlink
On Mon, Aug 11, 2014 at 09:14:58AM -0700, Jarno Rajahalme wrote:
> Add a new action type OVS_ACTION_ATTR_SET_MASKED, and support for
> parsing, printing, and committing them.
>
> Masked set actions add a mask, immediately following the netlink
> attribute data, within the netlink attribute itself.
On Mon, Aug 11, 2014 at 9:14 AM, Jarno Rajahalme wrote:
> diff --git a/tests/odp.at b/tests/odp.at
> index e725f70..58e3ff1 100644
> --- a/tests/odp.at
> +++ b/tests/odp.at
+set(ipv4(src=35.8.2.41/255.255.255.255,dst=172.16.0.20/255.255.255.255,proto=5/0xff,tos=0x80/0,ttl=128/0xff,frag=no/0xff))
>
Add a new action type OVS_ACTION_ATTR_SET_MASKED, and support for
parsing, printing, and committing them.
Masked set actions add a mask, immediately following the netlink
attribute data, within the netlink attribute itself. Thus the key
attribute size for a masked set action is exactly double of
