Re: [ovs-dev] [PATCH v4 1/3] Add basic implementation for OpenFlow 1.4 bundles

2014-04-29 Thread Ben Pfaff
On Wed, Apr 23, 2014 at 02:03:56PM +0300, Alexandru Copot wrote: > This is only the communication part of the bundles functionality. > The actual message pre-validation and commits are not implemented. > > Signed-off-by: Alexandru Copot Thanks for the new revision. I think that ofputil_decode_b

[ovs-dev] [PATCH v4 1/3] Add basic implementation for OpenFlow 1.4 bundles

2014-04-23 Thread Alexandru Copot
This is only the communication part of the bundles functionality. The actual message pre-validation and commits are not implemented. Signed-off-by: Alexandru Copot --- v4: * adjust copyright * fix style issues * remove all locking * delete bundles in ofconn_destroy() v3: * rebase * ad

Re: [ovs-dev] [PATCH v4 1/3] Add basic implementation for OpenFlow 1.4 bundles

2014-04-23 Thread Daniel Baluta
Hi Alex, On 04/22/2014 09:31 PM, Alexandru Copot wrote: +/* List of 'struct bundle_message's */ +struct list msg_list; +struct ovs_mutex list_mutex; I think we can remove this mutex too. Daniel. ___ dev mailing list dev@openvswitch

[ovs-dev] [PATCH v4 1/3] Add basic implementation for OpenFlow 1.4 bundles

2014-04-22 Thread Alexandru Copot
This is only the communication part of the bundles functionality. The actual message pre-validation and commits are not implemented. Signed-off-by: Alexandru Copot Cc: Daniel Baluta --- v4: * adjust copyright * fix style issues * remove locking in ofconn * delete bundles in ofconn_destro