Re: [ovs-dev] [PATCH v4 06/12] ofproto: Infra for table versioning.

2015-06-11 Thread Jarno Rajahalme
> On Jun 10, 2015, at 4:45 PM, Ben Pfaff wrote: > > On Tue, Jun 09, 2015 at 05:24:13PM -0700, Jarno Rajahalme wrote: >> Signed-off-by: Jarno Rajahalme > > In two places, the comment > >/* Set tables version after the bridge has been fixed. */ > > took me a while to follow ("Why was t

Re: [ovs-dev] [PATCH v4 06/12] ofproto: Infra for table versioning.

2015-06-10 Thread Ben Pfaff
On Tue, Jun 09, 2015 at 05:24:13PM -0700, Jarno Rajahalme wrote: > Signed-off-by: Jarno Rajahalme In two places, the comment /* Set tables version after the bridge has been fixed. */ took me a while to follow ("Why was the bridge broken?"). Maybe: /* The bridge is now known so

[ovs-dev] [PATCH v4 06/12] ofproto: Infra for table versioning.

2015-06-09 Thread Jarno Rajahalme
Signed-off-by: Jarno Rajahalme --- ofproto/ofproto-dpif-xlate.c | 17 - ofproto/ofproto-dpif.c | 43 +- ofproto/ofproto-dpif.h |5 - ofproto/ofproto-provider.h |6 ++ ofproto/ofproto.c|5