Re: [ovs-dev] [PATCH v4 05/10] Native Set-Field action.

2013-11-01 Thread Ben Pfaff
On Fri, Nov 01, 2013 at 03:22:34PM -0700, Jarno Rajahalme wrote: > Fair enough ;-) Thanks. I'm folding in the following additional changes, and then I'll apply this to master. The only really notable part of the changes that I made is that I'm feeling timid about silently adding and removing the

Re: [ovs-dev] [PATCH v4 05/10] Native Set-Field action.

2013-11-01 Thread Jarno Rajahalme
Fair enough ;-) Jarno On Nov 1, 2013, at 3:02 PM, Ben Pfaff wrote: > On Thu, Oct 24, 2013 at 01:19:29PM -0700, Jarno Rajahalme wrote: >> Signed-off-by: Jarno Rajahalme > > I'm going to fold this in: > > diff --git a/lib/ofp-actions.c b/lib/ofp-actions.c > index a9d4340..9f31449 100644 > --

Re: [ovs-dev] [PATCH v4 05/10] Native Set-Field action.

2013-11-01 Thread Ben Pfaff
On Thu, Oct 24, 2013 at 01:19:29PM -0700, Jarno Rajahalme wrote: > Signed-off-by: Jarno Rajahalme I'm going to fold this in: diff --git a/lib/ofp-actions.c b/lib/ofp-actions.c index a9d4340..9f31449 100644 --- a/lib/ofp-actions.c +++ b/lib/ofp-actions.c @@ -793,7 +793,7 @@ set_field_from_openflo

[ovs-dev] [PATCH v4 05/10] Native Set-Field action.

2013-10-24 Thread Jarno Rajahalme
Signed-off-by: Jarno Rajahalme --- v4: - Address review comments by Ben - Simplify implementation - Enforce presence of the OFPVID_PRESENT bit for Set-Field on OXM_OF_VLAN_VID. - Add OFPVID_PRESENT when parsing from string, and omit the bit when printing. - Explicitly check for header presence bef