Re: [ovs-dev] [PATCH v4 01/14] ofpbuf: New function ofpbuf_const_initializer().

2016-02-19 Thread Ben Pfaff
On Fri, Feb 19, 2016 at 01:48:06PM -0800, Jarno Rajahalme wrote: > With a note and a question below: > > Acked-by: Jarno Rajahalme Thanks for the review. > I’m curious if there is a specific reason to define > ofpbuf_const_initializer() as an inline function, and keep the > OFPBUF_STUB_INITIALI

Re: [ovs-dev] [PATCH v4 01/14] ofpbuf: New function ofpbuf_const_initializer().

2016-02-19 Thread Jarno Rajahalme
With a note and a question below: Acked-by: Jarno Rajahalme > On Feb 19, 2016, at 12:34 AM, Ben Pfaff wrote: > > A number of times I've looked at code and thought that it would be easier > to understand if I could write an initializer instead of > ofpbuf_use_const(). This commit adds a functi

[ovs-dev] [PATCH v4 01/14] ofpbuf: New function ofpbuf_const_initializer().

2016-02-19 Thread Ben Pfaff
A number of times I've looked at code and thought that it would be easier to understand if I could write an initializer instead of ofpbuf_use_const(). This commit adds a function for that purpose and adapts a lot of code to use it, in the places where I thought it made the code better. In theory