Re: [ovs-dev] [PATCH v4 01/12] netdev-dpdk: Consistent variable naming.

2016-03-21 Thread Ilya Maximets
A few comments inline. Best regards, Ilya Maximets. On 17.03.2016 02:39, Daniele Di Proietto wrote: > In different functions we use different variable names ('netdev_', 'netdev', > 'dev', 'vhost_dev', ...) for the same objects. > > This commit changes the code to comply with the following conven

[ovs-dev] [PATCH v4 01/12] netdev-dpdk: Consistent variable naming.

2016-03-19 Thread Daniele Di Proietto
In different functions we use different variable names ('netdev_', 'netdev', 'dev', 'vhost_dev', ...) for the same objects. This commit changes the code to comply with the following convention: 'struct netdev':'netdev' 'struct netdev_dpdk':'dev' 'struct virtio_net':'virtio_dev' 'struct netdev_rxq

Re: [ovs-dev] [PATCH v4 01/12] netdev-dpdk: Consistent variable naming.

2016-03-19 Thread Ilya Maximets
On 17.03.2016 02:39, Daniele Di Proietto wrote: > In different functions we use different variable names ('netdev_', 'netdev', > 'dev', 'vhost_dev', ...) for the same objects. > > This commit changes the code to comply with the following convention: > > 'struct netdev':'netdev' > 'struct netdev_d