Re: [ovs-dev] [PATCH v4 00/12] Reconfigure netdev at runtime

2016-03-23 Thread Daniele Di Proietto
Thanks for the detailed reviews Ilya! I've applied all your comments, your acked-by and tested-by. I found another bug in dp_netdev_free() and I fixed it. I've decided to send a v5, since I was hoping to get Ben's opinion on this. On 21/03/2016 06:48, "Ilya Maximets" wrote: >There are few sty

Re: [ovs-dev] [PATCH v4 00/12] Reconfigure netdev at runtime

2016-03-21 Thread Ilya Maximets
There are few style problems in patches. I've sent corresponding mails. Other than this: Tested-by: Ilya Maximets Acked-by: Ilya Maximets On 17.03.2016 02:39, Daniele Di Proietto wrote: > Currently we treat set_multiq() calls specially in netdev and dpif-netdev: > every pmd threa

[ovs-dev] [PATCH v4 00/12] Reconfigure netdev at runtime

2016-03-20 Thread Daniele Di Proietto
Currently we treat set_multiq() calls specially in netdev and dpif-netdev: every pmd thread must be stopped and set_multiq() is allowed to destroy and recreate the device. I think we can improve this by: * Generalizing the mechanism to allow changing other parameters at runtime (such as MTU). *

Re: [ovs-dev] [PATCH v4 00/12] Reconfigure netdev at runtime

2016-03-18 Thread Ilya Maximets
All looks good to me. I'll try to test this version tomorrow. Best regards, Ilya Maximets. On 17.03.2016 02:39, Daniele Di Proietto wrote: > Currently we treat set_multiq() calls specially in netdev and dpif-netdev: > every pmd thread must be stopped and set_multiq() is allowed to destroy and > r