Re: [ovs-dev] [PATCH v4] netdev-dpdk: Allow configurable queue sizes for 'dpdk' ports

2016-09-30 Thread Loftus, Ciara
> > 2016-09-29 3:28 GMT-07:00 Loftus, Ciara : > > > > Hi Ciara, > > thanks for the patch, it looks good to me. > > I only have a minor comment: > > I'd like the requested values to depend only on the current database > > state.  With the current patch when a value is invalid (not pow2 or bigger >

Re: [ovs-dev] [PATCH v4] netdev-dpdk: Allow configurable queue sizes for 'dpdk' ports

2016-09-29 Thread Daniele Di Proietto
2016-09-29 3:28 GMT-07:00 Loftus, Ciara : > > > > Hi Ciara, > > thanks for the patch, it looks good to me. > > I only have a minor comment: > > I'd like the requested values to depend only on the current database > > state. With the current patch when a value is invalid (not pow2 or > bigger > >

Re: [ovs-dev] [PATCH v4] netdev-dpdk: Allow configurable queue sizes for 'dpdk' ports

2016-09-29 Thread Loftus, Ciara
> > Hi Ciara, > thanks for the patch, it looks good to me. > I only have a minor comment: > I'd like the requested values to depend only on the current database > state.  With the current patch when a value is invalid (not pow2 or bigger > than 4096) we keep the previous one. > Could you change dp

Re: [ovs-dev] [PATCH v4] netdev-dpdk: Allow configurable queue sizes for 'dpdk' ports

2016-09-28 Thread Daniele Di Proietto
Hi Ciara, thanks for the patch, it looks good to me. I only have a minor comment: I'd like the requested values to depend only on the current database state. With the current patch when a value is invalid (not pow2 or bigger than 4096) we keep the previous one. Could you change dpdk_process_qu

Re: [ovs-dev] [PATCH v4] netdev-dpdk: Allow configurable queue sizes for 'dpdk' ports

2016-09-22 Thread Ilya Maximets
I didn't test that, but it looks good to me. Acked-by: Ilya Maximets ___ dev mailing list dev@openvswitch.org http://openvswitch.org/mailman/listinfo/dev

[ovs-dev] [PATCH v4] netdev-dpdk: Allow configurable queue sizes for 'dpdk' ports

2016-09-21 Thread Ciara Loftus
The 'options:n_rxq_desc' and 'n_txq_desc' fields allow the number of rx and tx descriptors for dpdk ports to be modified. By default the values are set to 2048, but can be modified to an integer between 1 and 4096 that is a power of two. The values can be modified at runtime, however require the NI