Re: [ovs-dev] [PATCH v4] gre: Restructure tunneling.

2013-06-06 Thread Jesse Gross
On Wed, Jun 5, 2013 at 6:30 PM, Pravin Shelar wrote: > I am planning on adding iptunnel_pull_header() function to upstream > kernel, it is in gre-upstream series that I am going to send. OK, it was somewhat difficult to review the compatibility code because it's a backport of something that isn't

Re: [ovs-dev] [PATCH v4] gre: Restructure tunneling.

2013-06-05 Thread Pravin Shelar
On Wed, Jun 5, 2013 at 5:46 PM, Jesse Gross wrote: > On Tue, Jun 4, 2013 at 1:31 PM, Pravin B Shelar wrote: >> diff --git a/datapath/compat.h b/datapath/compat.h >> index c7fd225..6095323 100644 >> --- a/datapath/compat.h >> +++ b/datapath/compat.h >> @@ -93,5 +93,11 @@ static inline void skb_set

Re: [ovs-dev] [PATCH v4] gre: Restructure tunneling.

2013-06-05 Thread Jesse Gross
On Tue, Jun 4, 2013 at 1:31 PM, Pravin B Shelar wrote: > diff --git a/datapath/compat.h b/datapath/compat.h > index c7fd225..6095323 100644 > --- a/datapath/compat.h > +++ b/datapath/compat.h > @@ -93,5 +93,11 @@ static inline void skb_set_mark(struct sk_buff *skb, u32 > mark) > skb->mark

[ovs-dev] [PATCH v4] gre: Restructure tunneling.

2013-06-04 Thread Pravin B Shelar
Following patch restructures ovs tunneling and gre vport implementation to make ovs tunneling more in sync with upstream kernel tunneling. Doing this tunneling code is simplified as most of protocol processing on send and recv is pushed to kernel tunneling. For external ovs module the code is mov