Re: [ovs-dev] [PATCH v3 7/7] lib/classifier: Lockless lookups.

2014-07-11 Thread Jarno Rajahalme
Series pushed to master, thanks for the reviews! On Jul 7, 2014, at 6:42 PM, YAMAMOTO Takashi wrote: > comments in ofproto-provider.h need an update. Done, thanks! > otherwise, looks good to me. > > how about unifying classifier and cls_classifier? > Good point. Earlier I had assumed I ne

Re: [ovs-dev] [PATCH v3 7/7] lib/classifier: Lockless lookups.

2014-07-07 Thread YAMAMOTO Takashi
> Now that all the relevant classifier structures use RCU and internal > mutual exclusion for modifications, we can remove the fat-rwlock and > thus make the classifier lookups lockless. > > As the readers are operating concurrently with the writers, a > concurrent reader may or may not see a new

[ovs-dev] [PATCH v3 7/7] lib/classifier: Lockless lookups.

2014-07-07 Thread Jarno Rajahalme
Now that all the relevant classifier structures use RCU and internal mutual exclusion for modifications, we can remove the fat-rwlock and thus make the classifier lookups lockless. As the readers are operating concurrently with the writers, a concurrent reader may or may not see a new rule being a