Re: [ovs-dev] [PATCH v3 1/3] tests: Check for core files before exiting.

2015-07-18 Thread Ben Pfaff
Actually I wonder if we're overlooking a bigger point. Are intermittent failures so common when you run the testsuite that you habitually do a recheck without looking at them? For me, they are not. I do see intermittent failures, but only occasionally; maybe 1 in 10 testsuite runs. That isn't s

Re: [ovs-dev] [PATCH v3 1/3] tests: Check for core files before exiting.

2015-07-18 Thread Ben Pfaff
On Fri, Jul 17, 2015 at 05:15:04PM -0700, Jarno Rajahalme wrote: > Ben, > > This works, the core file names can be found from the testsuite.log! > > It would be super nice to have the cores reported on the “Test Results” > section of the make check output, though: > > ## - ## > ## T

Re: [ovs-dev] [PATCH v3 1/3] tests: Check for core files before exiting.

2015-07-17 Thread Jarno Rajahalme
Ben, This works, the core file names can be found from the testsuite.log! It would be super nice to have the cores reported on the “Test Results” section of the make check output, though: ## - ## ## Test results. ## ## - ## ERROR: All 7 tests were run, 3 failed unexpect

Re: [ovs-dev] [PATCH v3 1/3] tests: Check for core files before exiting.

2015-07-17 Thread Ben Pfaff
OK, try this then: diff --git a/tests/daemon-py.at b/tests/daemon-py.at index cafa8df..b0f1236 100644 --- a/tests/daemon-py.at +++ b/tests/daemon-py.at @@ -59,7 +59,7 @@ AT_CHECK( AT_CHECK([kill `cat pid`], [0], [], [ignore], [kill `cat parent`]) OVS_WAIT_WHILE([kill -0 `cat parent` || kill -0 `

Re: [ovs-dev] [PATCH v3 1/3] tests: Check for core files before exiting.

2015-07-17 Thread Jarno Rajahalme
> On Jul 17, 2015, at 9:33 AM, Ben Pfaff wrote: > > On Thu, Jul 16, 2015 at 05:22:25PM -0700, Jarno Rajahalme wrote: >> >>> On Jul 16, 2015, at 4:33 PM, Ben Pfaff wrote: >>> >>> On Thu, Jul 16, 2015 at 03:15:52PM -0700, Jarno Rajahalme wrote: I've seen core files appear and then be autom

Re: [ovs-dev] [PATCH v3 1/3] tests: Check for core files before exiting.

2015-07-17 Thread Ben Pfaff
On Thu, Jul 16, 2015 at 05:22:25PM -0700, Jarno Rajahalme wrote: > > > On Jul 16, 2015, at 4:33 PM, Ben Pfaff wrote: > > > > On Thu, Jul 16, 2015 at 03:15:52PM -0700, Jarno Rajahalme wrote: > >> I've seen core files appear and then be automatically removed as the > >> test case was successful.

Re: [ovs-dev] [PATCH v3 1/3] tests: Check for core files before exiting.

2015-07-16 Thread Jarno Rajahalme
> On Jul 16, 2015, at 4:33 PM, Ben Pfaff wrote: > > On Thu, Jul 16, 2015 at 03:15:52PM -0700, Jarno Rajahalme wrote: >> I've seen core files appear and then be automatically removed as the >> test case was successful. Such success is highly doubtful, so fail >> the test cases if any core files

Re: [ovs-dev] [PATCH v3 1/3] tests: Check for core files before exiting.

2015-07-16 Thread Ben Pfaff
On Thu, Jul 16, 2015 at 03:15:52PM -0700, Jarno Rajahalme wrote: > I've seen core files appear and then be automatically removed as the > test case was successful. Such success is highly doubtful, so fail > the test cases if any core files exist at the end of the test. > > Signed-off-by: Jarno Ra

[ovs-dev] [PATCH v3 1/3] tests: Check for core files before exiting.

2015-07-16 Thread Jarno Rajahalme
I've seen core files appear and then be automatically removed as the test case was successful. Such success is highly doubtful, so fail the test cases if any core files exist at the end of the test. Signed-off-by: Jarno Rajahalme --- tests/ofproto-macros.at |6 +- 1 file changed, 5 inse