On Fri, Jun 06, 2014 at 05:13:13PM -0700, Daniele Di Proietto wrote:
> This commit introduces a new data structure used for receiving packets from
> netdevs and passing them to dpifs.
> The purpose of this change is to allow storing some private data for each
> packet. The subsequent commits make u
> On Jun 6, 2014, at 10:03 PM, Daniele Di Proietto
> wrote:
>
>> - Related to the above, I don't see why cloning an ofpbuf to the dpif_packet
>> should be necessary. Maybe later patches get rid of the copying?
>
> It is necessary, for example in dpif_netdev_execute: we get an ofpbuf and we
>
void adding dpif_packet (for now).
Thanks,
Daniele
- Original Message -
From: "Jarno Rajahalme"
To: "Daniele Di Proietto"
Cc: dev@openvswitch.org
Sent: Friday, June 6, 2014 8:04:37 PM
Subject: Re: [ovs-dev] [PATCH v3 1/3] dpif-netdev: use dpif_packet structure
for packe
Some high-level comments for now:
- dpif_packet should not be defined ofpbuf.h. If it is exposed in the dpif API,
then it should be in dpif-provider.h, if it is private to dpif-netdev, then
somewhere else.
- I would prefer not try to hide that dpif_packet contains an ofpbuf, i.e., do
not intro
This commit introduces a new data structure used for receiving packets from
netdevs and passing them to dpifs.
The purpose of this change is to allow storing some private data for each
packet. The subsequent commits make use of it.
Signed-off-by: Daniele Di Proietto
---
lib/dpif-netdev.c
