Re: [ovs-dev] [PATCH v3 1/2] dpif-netdev: Rework of rx queue management.

2016-01-25 Thread Ilya Maximets
Thanks for review. I'll prepare new version. Best regards, Ilya Maximets. On 26.01.2016 03:21, Daniele Di Proietto wrote: > Hi, > > Thanks again for the patch, > > As I said in the discussion of v2, I think we should keep the > condition variable, so that we can return from the datapath > func

Re: [ovs-dev] [PATCH v3 1/2] dpif-netdev: Rework of rx queue management.

2016-01-25 Thread Daniele Di Proietto
Hi, Thanks again for the patch, As I said in the discussion of v2, I think we should keep the condition variable, so that we can return from the datapath functions when the port operations are effectively completed. I also have a couple of minor coding style suggestions (inline). Other than th

[ovs-dev] [PATCH v3 1/2] dpif-netdev: Rework of rx queue management.

2016-01-25 Thread Ilya Maximets
Current rx queue management model is buggy and will not work properly without additional barriers and other syncronization between PMD threads and main thread. Known BUGS of current model: * While reloading, two PMD threads, one already reloaded and one not yet reloaded, can poll