Re: [ovs-dev] [PATCH v3 06/12] ofp-actions: implement instruction encoder

2012-07-24 Thread Ben Pfaff
On Mon, Jul 23, 2012 at 05:08:45PM +0900, Isaku Yamahata wrote: > Signed-off-by: Isaku Yamahata This seems reasonable enough, other than the #if 0...#endif block that it introduces (was that intentional?). It would be good to add some tests to tests/ofp-actions.at at this point, in the test: AT_

[ovs-dev] [PATCH v3 06/12] ofp-actions: implement instruction encoder

2012-07-23 Thread Isaku Yamahata
Signed-off-by: Isaku Yamahata --- v3 - changed for OFPACT_{CLEAR_ACTIONS, WRITE_ACTIONS, GOTO_TABLE} v2 - changed for ofp_instruction --- lib/ofp-actions.c | 66 +++- lib/ofp-util.c| 26 + 2 files changed, 75 insertions(