Re: [ovs-dev] [PATCH v3 06/11] Native OpenFlow 1.2 set field action.

2013-10-24 Thread Jarno Rajahalme
On Oct 23, 2013, at 9:14 PM, Ben Pfaff wrote: > On Wed, Oct 23, 2013 at 12:53:01PM -0700, Jarno Rajahalme wrote: >> Signed-off-by: Jarno Rajahalme > > Is MFF_VLAN_VID the only field for which the "match" and "set" > prerequisites differ? If so, then I'd like to think of some way to > avoid ha

Re: [ovs-dev] [PATCH v3 06/11] Native OpenFlow 1.2 set field action.

2013-10-24 Thread Jarno Rajahalme
Ben, OpenFlow 1.3.3 is much more specific about handling the VID with set-field action. It states that the OFPVID_PRESENT bit must be on, and that the switch behavior when VLAN header does not exist is implementation-dependent: "The use of a set-fi eld action assumes that the corresponding header

Re: [ovs-dev] [PATCH v3 06/11] Native OpenFlow 1.2 set field action.

2013-10-23 Thread Jarno Rajahalme
Ben, Thanks for your comments. I just checked the recently (?) published OpenFlow 1.3.3 spec and it has more specific language about Set Field action which relevant in this context. Set Field on VID must have the OFPVID_PRESENT bit set, so at the minimum it means that we should take in all the

Re: [ovs-dev] [PATCH v3 06/11] Native OpenFlow 1.2 set field action.

2013-10-23 Thread Ben Pfaff
On Wed, Oct 23, 2013 at 12:53:01PM -0700, Jarno Rajahalme wrote: > Signed-off-by: Jarno Rajahalme Is MFF_VLAN_VID the only field for which the "match" and "set" prerequisites differ? If so, then I'd like to think of some way to avoid having twice as many prerequisites that one could get wrong. O

[ovs-dev] [PATCH v3 06/11] Native OpenFlow 1.2 set field action.

2013-10-23 Thread Jarno Rajahalme
Signed-off-by: Jarno Rajahalme --- lib/meta-flow.c | 203 ++ lib/meta-flow.h | 20 - lib/nx-match.c | 135 ++-- lib/nx-match.h |2 - lib/ofp-actions.c| 14