Re: [ovs-dev] [PATCH v3 03/11] OF 1.1 set vlan vid/pcp compatibility.

2013-10-24 Thread Ben Pfaff
I don't think you should put in that work yet, I'm thinking it over and wouldn't want you to spend time on it that might be wasted. On Thu, Oct 24, 2013 at 09:10:06AM -0700, Jarno Rajahalme wrote: > Ben, > > While I'm reworking on the series, I could add the separate actions for the > OF 1.1 set

Re: [ovs-dev] [PATCH v3 03/11] OF 1.1 set vlan vid/pcp compatibility.

2013-10-24 Thread Jarno Rajahalme
Ben, While I'm reworking on the series, I could add the separate actions for the OF 1.1 set VLAN VID/PCP actions if you think it will make the code easier to read and maintain. If we do this, we should think about separating the PUSH MPLS actions as well. Please let me know, Jarno On Oct 23

Re: [ovs-dev] [PATCH v3 03/11] OF 1.1 set vlan vid/pcp compatibility.

2013-10-23 Thread Jarno Rajahalme
I guess it is analogous to the way the OF 1.3 MPLS sematic difference is being treated now, and also the thought that maybe the separate OF 1.1 actions will not find much use in practice, as they are deprecated in OF 1.2. Jarno On Oct 23, 2013, at 3:58 PM, Ben Pfaff wrote: > That's OK, but

Re: [ovs-dev] [PATCH v3 03/11] OF 1.1 set vlan vid/pcp compatibility.

2013-10-23 Thread Ben Pfaff
That's OK, but can you fill me in on what tipped the scales toward single actions? On Wed, Oct 23, 2013 at 03:02:23PM -0700, Jarno Rajahalme wrote: > I actually had different ofpacts for these, but then decided to > ditch them, so if you do not insist, I'd rather not bring em back > :-) > > Jar

Re: [ovs-dev] [PATCH v3 03/11] OF 1.1 set vlan vid/pcp compatibility.

2013-10-23 Thread Jarno Rajahalme
I actually had different ofpacts for these, but then decided to ditch them, so if you do not insist, I'd rather not bring em back :-) Jarno > On Oct 23, 2013, at 2:53 PM, Ben Pfaff wrote: > >> On Wed, Oct 23, 2013 at 12:52:58PM -0700, Jarno Rajahalme wrote: >> OpenFlow 1.1 set vlan actions

Re: [ovs-dev] [PATCH v3 03/11] OF 1.1 set vlan vid/pcp compatibility.

2013-10-23 Thread Ben Pfaff
On Wed, Oct 23, 2013 at 12:52:58PM -0700, Jarno Rajahalme wrote: > OpenFlow 1.1 set vlan actions only modify existing vlan > headers, while OF 1.0 actions push a new vlan header if one > does not exist already. > > Signed-off-by: Jarno Rajahalme Do you have a feeling whether the OF1.0 and OF1.1

[ovs-dev] [PATCH v3 03/11] OF 1.1 set vlan vid/pcp compatibility.

2013-10-23 Thread Jarno Rajahalme
OpenFlow 1.1 set vlan actions only modify existing vlan headers, while OF 1.0 actions push a new vlan header if one does not exist already. Signed-off-by: Jarno Rajahalme --- lib/ofp-actions.c| 91 +- lib/ofp-actions.h| 20 +