On Fri, Oct 21, 2011 at 2:19 PM, Jesse Gross wrote:
> On Fri, Oct 21, 2011 at 2:14 PM, Pravin B Shelar wrote:
>> This is incremental patch to 'Refactor actions' patch posted. Fixed
>> according to comments from Jesse.
>>
>> Signed-off-by: Pravin Shelar
>
> Looks good, thanks.
>
> The whole thing
On Fri, Oct 21, 2011 at 2:14 PM, Pravin B Shelar wrote:
> This is incremental patch to 'Refactor actions' patch posted. Fixed
> according to comments from Jesse.
>
> Signed-off-by: Pravin Shelar
Looks good, thanks.
The whole thing:
Acked-by: Jesse Gross
This is incremental patch to 'Refactor actions' patch posted. Fixed
according to comments from Jesse.
Signed-off-by: Pravin Shelar
---
datapath/datapath.c | 12 +++-
lib/dpif-netdev.c |1 +
lib/odp-util.c |2 +-
3 files changed, 9 insertions(+), 6 deletions(-)
diff --gi
On Thu, Oct 20, 2011 at 4:55 PM, Pravin B Shelar wrote:
> +static int validate_action_key(int act_type, const struct nlattr *ovs_key,
> int act_len,
> + const struct sw_flow_key *flow_key)
> +{
I think it's clearer if you just pass the nlattr for the action since
right now you are
On Thu, Oct 20, 2011 at 04:55:44PM -0700, Pravin B Shelar wrote:
> changes:
> - datapath validation for SET and PUSH actions.
> - fixed comments.
> - cleanup commit_odp_* functions.
> v2:
> Fixed according to comments from Jesse.
I have no further comments on the userspace
changes:
- datapath validation for SET and PUSH actions.
- fixed comments.
- cleanup commit_odp_* functions.
v2:
Fixed according to comments from Jesse.
--8<--cut here-->8--
Almost all current actions can be expressed in the f
