Re: [ovs-dev] [PATCH v3] datapath: NUMA node flow stats.

2014-02-04 Thread Pravin Shelar
On Tue, Feb 4, 2014 at 9:03 AM, Jarno Rajahalme wrote: > Pravin, > > Thanks for your thorough review. Some comments below, > > Jarno > > On Feb 3, 2014, at 9:14 AM, Pravin Shelar wrote: > > On Thu, Jan 23, 2014 at 4:43 PM, Jarno Rajahalme > wrote: > > > ... > > +static void get_skb_stats(struc

Re: [ovs-dev] [PATCH v3] datapath: NUMA node flow stats.

2014-02-04 Thread Jarno Rajahalme
Pravin, Thanks for your thorough review. Some comments below, Jarno On Feb 3, 2014, at 9:14 AM, Pravin Shelar wrote: > On Thu, Jan 23, 2014 at 4:43 PM, Jarno Rajahalme > wrote: >> ... >> +static void get_skb_stats(struct flow_stats *stat, const struct sw_flow >> *flow, >> +

Re: [ovs-dev] [PATCH v3] datapath: NUMA node flow stats.

2014-02-03 Thread Pravin Shelar
On Thu, Jan 23, 2014 at 4:43 PM, Jarno Rajahalme wrote: > Keep kernel flow stats for each NUMA node rather than each (logical) > CPU. This avoids using the per-CPU allocator and removes most of the > kernel-side OVS locking overhead otherwise on the top of perf report > and allows OVS to scale be

[ovs-dev] [PATCH v3] datapath: NUMA node flow stats.

2014-01-23 Thread Jarno Rajahalme
Keep kernel flow stats for each NUMA node rather than each (logical) CPU. This avoids using the per-CPU allocator and removes most of the kernel-side OVS locking overhead otherwise on the top of perf report and allows OVS to scale better with higher number of threads. With 9 handlers and 4 revali