Re: [ovs-dev] [PATCH v3] Extend OVS IPFIX exporter to export tunnel headers

2014-07-18 Thread Wenyu Zhang
I have addressed all the comments and sent out another version of the patch, may you help? Thanks Wenyu -Original Message- From: Pravin Shelar [mailto:pshe...@nicira.com] Sent: Friday, July 18, 2014 12:00 PM To: Wenyu Zhang Cc: Romain Lenglet; Ben Pfaff; Jesse Gross; dev@openvswitch.or

Re: [ovs-dev] [PATCH v3] Extend OVS IPFIX exporter to export tunnel headers

2014-07-17 Thread Pravin Shelar
On Thu, Jul 17, 2014 at 8:20 PM, Wenyu Zhang wrote: > > > -Original Message- > From: Pravin Shelar [mailto:pshe...@nicira.com] > Sent: Friday, July 18, 2014 1:20 AM > To: Wenyu Zhang > Cc: Romain Lenglet; Ben Pfaff; Jesse Gross; dev@openvswitch.org > Subject: Re: [PATCH v3] Extend OVS IPFI

Re: [ovs-dev] [PATCH v3] Extend OVS IPFIX exporter to export tunnel headers

2014-07-17 Thread Wenyu Zhang
-Original Message- From: Pravin Shelar [mailto:pshe...@nicira.com] Sent: Friday, July 18, 2014 1:20 AM To: Wenyu Zhang Cc: Romain Lenglet; Ben Pfaff; Jesse Gross; dev@openvswitch.org Subject: Re: [PATCH v3] Extend OVS IPFIX exporter to export tunnel headers On Thu, Jul 17, 2014 at 3:05

Re: [ovs-dev] [PATCH v3] Extend OVS IPFIX exporter to export tunnel headers

2014-07-17 Thread Pravin Shelar
On Thu, Jul 17, 2014 at 3:05 AM, Wenyu Zhang wrote: > Thanks for the review. > > I have removed the incorrect whitespaces. > > About XXX_get_out_tun_info(), I keep the caluclation of saddr, including > route look up process, tp_src and tp_dst in ops for each vport, due to that > the process are

Re: [ovs-dev] [PATCH v3] Extend OVS IPFIX exporter to export tunnel headers

2014-07-17 Thread Wenyu Zhang
Thanks for the review. I have removed the incorrect whitespaces. About XXX_get_out_tun_info(), I keep the caluclation of saddr, including route look up process, tp_src and tp_dst in ops for each vport, due to that the process are a little different for each vport. And I think that the potent

Re: [ovs-dev] [PATCH v3] Extend OVS IPFIX exporter to export tunnel headers

2014-07-16 Thread Pravin Shelar
git am warning: Applying: Extend OVS IPFIX exporter to export tunnel headers /home/pravin/ovs/w8/.git/rebase-apply/patch:143: trailing whitespace. if (out_tun_key) /home/pravin/ovs/w8/.git/rebase-apply/patch:236: space before tab in indent. const struct udphdr * udp_hdr = tph; /home