Re: [ovs-dev] [PATCH v3] Add Support for 802.1qad (qinq) Allows TPID of 0x88a8

2014-04-17 Thread Avinash
stacked VLAN support (OF1.2+ spec) with this design. -- Avinash On 4/15/14, Manikanta Srinivas wrote: > Thanks for the reply. Please find my responses inline. > >> Date: Mon, 14 Apr 2014 07:11:11 -0700 >> Subject: Re: [ovs-dev] [PATCH v3] Add Support for 802.1qad (qinq) Allows

Re: [ovs-dev] [PATCH v3] Add Support for 802.1qad (qinq) Allows TPID of 0x88a8

2014-04-15 Thread Manikanta Srinivas
Thanks for the reply. Please find my responses inline. > Date: Mon, 14 Apr 2014 07:11:11 -0700 > Subject: Re: [ovs-dev] [PATCH v3] Add Support for 802.1qad (qinq) Allows TPID > of 0x88a8 > From: az...@nicira.com > To: srinivas...@outlook.com > CC: thomasfherb...@gmail.com; d

Re: [ovs-dev] [PATCH] V3 Add Support for 802.1qad (qinq) Allows TPID of 0x88a8

2014-04-15 Thread Thomas F Herbert
Andy, Thanks for your detailed feedback. On 4/14/2014 5:31 PM, Andy Zhou wrote: It would be great if your next rebased patch also provide some information on what has been tested. Some higher level feedback follows, Minor feedback inline. Patch format: For ease of up-streaming to Linux kenre

Re: [ovs-dev] [PATCH v3] Add Support for 802.1qad (qinq) Allows TPID of 0x88a8

2014-04-14 Thread Andy Zhou
Supporting 9100, or even 8100 would be nice if they are easy. If we have to make a choice, I'd rank 88a8, followed by 9100, then 8100. My understanding is that 9100 was fairly popular in older networking equipments. Openflow1.1 only requires 88a8. On Mon, Apr 14, 2014 at 8:05 AM, Thomas F Herbert

Re: [ovs-dev] [PATCH] V3 Add Support for 802.1qad (qinq) Allows TPID of 0x88a8

2014-04-14 Thread Andy Zhou
It would be great if your next rebased patch also provide some information on what has been tested. Some higher level feedback follows, Minor feedback inline. Patch format: For ease of up-streaming to Linux kenrel, we should split the patch into two parts. One for kernel datapath, one for OVS us

Re: [ovs-dev] [PATCH v3] Add Support for 802.1qad (qinq) Allows TPID of 0x88a8

2014-04-14 Thread Thomas F Herbert
Andy and Manikanta, I agree with Andy/ I don't think there is a necessity for any design changes in OVS for qinq at least for Open Flow 1.1. I am working on debugging/testing the patch now. Right now I am working on debugging my double tagging patch as specified in 802.1ad with an outer TPI

Re: [ovs-dev] [PATCH v3] Add Support for 802.1qad (qinq) Allows TPID of 0x88a8

2014-04-14 Thread Andy Zhou
On Mon, Apr 14, 2014 at 4:27 AM, Manikanta Srinivas wrote: > Hi, > > Thanks for your efforts. We are interested in QinQ implementation of > openvswitch. After going through the patch, we are left with following > queries. > > 1. We think there should be a separate mode to support qinq tunnel. This

Re: [ovs-dev] [PATCH v3] Add Support for 802.1qad (qinq) Allows TPID of 0x88a8

2014-04-14 Thread Manikanta Srinivas
Hi, Thanks for your efforts. We are interested in QinQ implementation of openvswitch. After going through the patch, we are left with following queries. 1. We think there should be a separate mode to support qinq tunnel. This can be achieved by implementing a new configuration parameter

[ovs-dev] [PATCH] V3 Add Support for 802.1qad (qinq) Allows TPID of 0x88a8

2014-04-13 Thread Tom Herbert
Signed-off-by: Tom Herbert --- NEWS|1 + datapath/actions.c | 16 datapath/flow_netlink.c | 15 +-- include/linux/openvswitch.h | 12 ++-- lib/odp-execute.c |2 +- lib/odp-util.c |2

[ovs-dev] [PATCH v3] Add Support for 802.1qad (qinq) Allows TPID of 0x88a8

2014-04-13 Thread Tom Herbert
This is a reformatted patch to fix problem reported to me by Andy with the patch format. Tom Herbert (1): V3 Add Support for 802.1qad (qinq) Allows TPID of 0x88a8 NEWS|1 + datapath/actions.c | 16 datapath/flow_netlink.c | 15