Re: [ovs-dev] [PATCH v2 5/5] ofproto-dpif: Use ovs_refcount_try_ref_rcu().

2014-07-07 Thread Ben Pfaff
Great, thanks. On Mon, Jul 07, 2014 at 02:16:29PM -0700, Jarno Rajahalme wrote: > This small change made the last patch of the original series not > apply any more, I?ll send a rebased v3 series out in a moment to > keep things simple. No other changes, so if reviews are underway, > they should ap

Re: [ovs-dev] [PATCH v2 5/5] ofproto-dpif: Use ovs_refcount_try_ref_rcu().

2014-07-07 Thread Jarno Rajahalme
This small change made the last patch of the original series not apply any more, I’ll send a rebased v3 series out in a moment to keep things simple. No other changes, so if reviews are underway, they should apply as-is. Jarno On Jul 7, 2014, at 1:40 PM, Jarno Rajahalme wrote: > Thanks for

Re: [ovs-dev] [PATCH v2 5/5] ofproto-dpif: Use ovs_refcount_try_ref_rcu().

2014-07-07 Thread Jarno Rajahalme
Thanks for the reviews, series pushed with suggested changes (upto this patch), Jarno On Jul 7, 2014, at 9:47 AM, Ben Pfaff wrote: > On Fri, Jul 04, 2014 at 07:21:19AM -0700, Jarno Rajahalme wrote: >> This is a prerequisite step in making the classifier lookups lockless. >> If taking a refere

Re: [ovs-dev] [PATCH v2 5/5] ofproto-dpif: Use ovs_refcount_try_ref_rcu().

2014-07-07 Thread Ben Pfaff
On Fri, Jul 04, 2014 at 07:21:19AM -0700, Jarno Rajahalme wrote: > This is a prerequisite step in making the classifier lookups lockless. > If taking a reference fails, we do the lookup again, as a new (lower > priority) rule may now match instead. > > Also remove unwildcarding dl_type and nw_frag

[ovs-dev] [PATCH v2 5/5] ofproto-dpif: Use ovs_refcount_try_ref_rcu().

2014-07-04 Thread Jarno Rajahalme
This is a prerequisite step in making the classifier lookups lockless. If taking a reference fails, we do the lookup again, as a new (lower priority) rule may now match instead. Also remove unwildcarding dl_type and nw_frag, as these are already taken care of by xlate_actions(). Signed-off-by: Ja