Re: [ovs-dev] [PATCH v2 3/5] python: Convert dict iterators.

2016-01-21 Thread Ben Pfaff
On Thu, Jan 21, 2016 at 11:01:42PM -0500, Russell Bryant wrote: > There's also a trivial patch #5 without a review, but I can also just > include it as the first patch on the next series. I read it and I thought I reviewed it. Let me try again. ___ dev

Re: [ovs-dev] [PATCH v2 3/5] python: Convert dict iterators.

2016-01-21 Thread Russell Bryant
On 01/20/2016 06:26 PM, Ben Pfaff wrote: > Acked-by: Ben Pfaff Thanks, I pushed this patch to master. There's also a trivial patch #5 without a review, but I can also just include it as the first patch on the next series. -- Russell Bryant ___ dev ma

Re: [ovs-dev] [PATCH v2 3/5] python: Convert dict iterators.

2016-01-20 Thread Ben Pfaff
On Wed, Jan 20, 2016 at 05:04:24PM -0500, Russell Bryant wrote: > On 01/20/2016 04:25 PM, Ben Pfaff wrote: > > On Tue, Jan 12, 2016 at 02:45:47PM -0500, Russell Bryant wrote: > >> In Python 2, dict.items(), dict.keys(), and dict.values() returned a > >> list. dict.iteritems(), dict.iterkeys(), and

Re: [ovs-dev] [PATCH v2 3/5] python: Convert dict iterators.

2016-01-20 Thread Russell Bryant
On 01/20/2016 04:25 PM, Ben Pfaff wrote: > On Tue, Jan 12, 2016 at 02:45:47PM -0500, Russell Bryant wrote: >> In Python 2, dict.items(), dict.keys(), and dict.values() returned a >> list. dict.iteritems(), dict.iterkeys(), and dict.itervalues() returned >> an iterator. >> >> As of Python 3, dict.i

Re: [ovs-dev] [PATCH v2 3/5] python: Convert dict iterators.

2016-01-20 Thread Ben Pfaff
On Tue, Jan 12, 2016 at 02:45:47PM -0500, Russell Bryant wrote: > In Python 2, dict.items(), dict.keys(), and dict.values() returned a > list. dict.iteritems(), dict.iterkeys(), and dict.itervalues() returned > an iterator. > > As of Python 3, dict.iteritems(), dict.itervalues(), and dict.iterkey

[ovs-dev] [PATCH v2 3/5] python: Convert dict iterators.

2016-01-12 Thread Russell Bryant
In Python 2, dict.items(), dict.keys(), and dict.values() returned a list. dict.iteritems(), dict.iterkeys(), and dict.itervalues() returned an iterator. As of Python 3, dict.iteritems(), dict.itervalues(), and dict.iterkeys() are gone. items(), keys(), and values() now return an iterator. In t