Re: [ovs-dev] [PATCH v2 3/3] ovn: Add address_set() support for ACLs.

2016-05-01 Thread Han Zhou
One more comment, if you will be working on v3. On Thu, Apr 7, 2016 at 8:46 AM, Russell Bryant wrote: > diff --git a/ovn/ovn-nb.ovsschema b/ovn/ovn-nb.ovsschema > index 40a7a97..c26d8ae 100644 > --- a/ovn/ovn-nb.ovsschema > +++ b/ovn/ovn-nb.ovsschema > @@ -1,7 +1,7 @@ > { > "name": "OVN_Nor

Re: [ovs-dev] [PATCH v2 3/3] ovn: Add address_set() support for ACLs.

2016-04-11 Thread Ben Pfaff
On Thu, Apr 07, 2016 at 01:05:25PM -0700, Nirapada Ghosh wrote: > I am sure this enhancement is going to take care of the problem I am > looking at. Adding a port on top of 200 ports is taking around a minute and > majority of the time is being spent on calling _add_acl() [from create_port > () in

Re: [ovs-dev] [PATCH v2 3/3] ovn: Add address_set() support for ACLs.

2016-04-07 Thread Russell Bryant
On Thu, Apr 7, 2016 at 3:52 PM, Ryan Moats wrote: > "dev" wrote on 04/07/2016 10:46:45 AM: > > > From: Russell Bryant > > To: dev@openvswitch.org > > Date: 04/07/2016 10:47 AM > > Subject: [ovs-dev] [PATCH v2 3/3] ovn: Add address_set() support for

Re: [ovs-dev] [PATCH v2 3/3] ovn: Add address_set() support for ACLs.

2016-04-07 Thread Russell Bryant
On Thu, Apr 7, 2016 at 12:04 PM, Nirapada Ghosh wrote: > I am sure this enhancement is going to take care of the problem I am > looking at. Adding a port on top of 200 ports is taking around a minute and > majority of the time is being spent on calling _add_acl() [from > create_port() in OVN plug

Re: [ovs-dev] [PATCH v2 3/3] ovn: Add address_set() support for ACLs.

2016-04-07 Thread Nirapada Ghosh
I am sure this enhancement is going to take care of the problem I am looking at. Adding a port on top of 200 ports is taking around a minute and majority of the time is being spent on calling _add_acl() [from create_port () in OVN plugin] for 200 times, each of which is taking about 1/4th of a sec

Re: [ovs-dev] [PATCH v2 3/3] ovn: Add address_set() support for ACLs.

2016-04-07 Thread Ryan Moats
"dev" wrote on 04/07/2016 10:46:45 AM: > From: Russell Bryant > To: dev@openvswitch.org > Date: 04/07/2016 10:47 AM > Subject: [ovs-dev] [PATCH v2 3/3] ovn: Add address_set() support for ACLs. > Sent by: "dev" > > This feature was originally pr

[ovs-dev] [PATCH v2 3/3] ovn: Add address_set() support for ACLs.

2016-04-07 Thread Russell Bryant
This feature was originally proposed here: http://openvswitch.org/pipermail/dev/2016-March/067440.html A common use case for OVN ACLs involves needing to match a set of IP addresses. outport == "lp1" && ip4.src == {10.0.0.5, 10.0.0.25, 10.0.0.50} This example match only has 3 addresses, bu