Re: [ovs-dev] [PATCH v2 2/9] lib/util: Add ctz64() and popcount64().

2013-11-18 Thread Jarno Rajahalme
On Nov 18, 2013, at 2:31 PM, Ben Pfaff wrote: > On Mon, Nov 18, 2013 at 02:24:52PM -0800, Jarno Rajahalme wrote: >> I forgot about that mail over the weekend, sorry. IO just caked your patches. > > This expression is new to me, what does it mean? A typo and iMail spell “correct” at work, it se

Re: [ovs-dev] [PATCH v2 2/9] lib/util: Add ctz64() and popcount64().

2013-11-18 Thread Ben Pfaff
On Mon, Nov 18, 2013 at 02:24:52PM -0800, Jarno Rajahalme wrote: > I forgot about that mail over the weekend, sorry. IO just caked your patches. This expression is new to me, what does it mean? ___ dev mailing list dev@openvswitch.org http://openvswitch.

Re: [ovs-dev] [PATCH v2 2/9] lib/util: Add ctz64() and popcount64().

2013-11-18 Thread Jarno Rajahalme
Ben, I forgot about that mail over the weekend, sorry. IO just caked your patches. Jarno On Nov 18, 2013, at 1:20 PM, Ben Pfaff wrote: > I guess you missed this. No matter, I sent out a couple of patches: > http://openvswitch.org/pipermail/dev/2013-November/034035.html > http://openvswitch.

Re: [ovs-dev] [PATCH v2 2/9] lib/util: Add ctz64() and popcount64().

2013-11-18 Thread Ben Pfaff
I guess you missed this. No matter, I sent out a couple of patches: http://openvswitch.org/pipermail/dev/2013-November/034035.html http://openvswitch.org/pipermail/dev/2013-November/034036.html On Fri, Nov 15, 2013 at 4:06 PM, Ben Pfaff wrote: > On Fri, Nov 15, 2013 at 03:48:58PM -0800, Ben Pf

Re: [ovs-dev] [PATCH v2 2/9] lib/util: Add ctz64() and popcount64().

2013-11-18 Thread Jarno Rajahalme
Pushed to master, Jarno On Nov 15, 2013, at 4:15 PM, Jarno Rajahalme wrote: > >> On Nov 15, 2013, at 4:08 PM, Ben Pfaff wrote: >> >>> On Fri, Nov 15, 2013 at 04:03:32PM -0800, Jarno Rajahalme wrote: >>> > On Nov 15, 2013, at 3:48 PM, Ben Pfaff wrote: > > On Wed, Nov 13, 2013

Re: [ovs-dev] [PATCH v2 2/9] lib/util: Add ctz64() and popcount64().

2013-11-15 Thread Jarno Rajahalme
> On Nov 15, 2013, at 4:08 PM, Ben Pfaff wrote: > >> On Fri, Nov 15, 2013 at 04:03:32PM -0800, Jarno Rajahalme wrote: >> On Nov 15, 2013, at 3:48 PM, Ben Pfaff wrote: On Wed, Nov 13, 2013 at 01:32:42PM -0800, Jarno Rajahalme wrote: Add raw_ctz64(), ctz64(), and popcount64(

Re: [ovs-dev] [PATCH v2 2/9] lib/util: Add ctz64() and popcount64().

2013-11-15 Thread Ben Pfaff
On Fri, Nov 15, 2013 at 04:03:32PM -0800, Jarno Rajahalme wrote: > > > On Nov 15, 2013, at 3:48 PM, Ben Pfaff wrote: > > > >> On Wed, Nov 13, 2013 at 01:32:42PM -0800, Jarno Rajahalme wrote: > >> Add raw_ctz64(), ctz64(), and popcount64() using builtins when > >> available. > >> > >> I'm not su

Re: [ovs-dev] [PATCH v2 2/9] lib/util: Add ctz64() and popcount64().

2013-11-15 Thread Ben Pfaff
On Fri, Nov 15, 2013 at 03:48:58PM -0800, Ben Pfaff wrote: > On Wed, Nov 13, 2013 at 01:32:42PM -0800, Jarno Rajahalme wrote: > > Add raw_ctz64(), ctz64(), and popcount64() using builtins when > > available. > > > > I'm not sure if the "UINT64_MAX == ~0UL" and "UINT64_MAX == ~0ULL" > > work in all

Re: [ovs-dev] [PATCH v2 2/9] lib/util: Add ctz64() and popcount64().

2013-11-15 Thread Jarno Rajahalme
> On Nov 15, 2013, at 3:48 PM, Ben Pfaff wrote: > >> On Wed, Nov 13, 2013 at 01:32:42PM -0800, Jarno Rajahalme wrote: >> Add raw_ctz64(), ctz64(), and popcount64() using builtins when >> available. >> >> I'm not sure if the "UINT64_MAX == ~0UL" and "UINT64_MAX == ~0ULL" >> work in all cases as

Re: [ovs-dev] [PATCH v2 2/9] lib/util: Add ctz64() and popcount64().

2013-11-15 Thread Ben Pfaff
On Wed, Nov 13, 2013 at 01:32:42PM -0800, Jarno Rajahalme wrote: > Add raw_ctz64(), ctz64(), and popcount64() using builtins when > available. > > I'm not sure if the "UINT64_MAX == ~0UL" and "UINT64_MAX == ~0ULL" > work in all cases as I imagine they would. I think you could use ULONG_MAX and UL

[ovs-dev] [PATCH v2 2/9] lib/util: Add ctz64() and popcount64().

2013-11-13 Thread Jarno Rajahalme
Add raw_ctz64(), ctz64(), and popcount64() using builtins when available. I'm not sure if the "UINT64_MAX == ~0UL" and "UINT64_MAX == ~0ULL" work in all cases as I imagine they would. Signed-off-by: Jarno Rajahalme --- lib/util.h| 51 +--- tests/tes