Re: [ovs-dev] [PATCH v2 2/7] tests: Port test-sflow and test-netflow to windows.

2014-06-27 Thread Ben Pfaff
On Fri, Jun 27, 2014 at 03:22:29PM -0700, Gurucharan Shetty wrote: > On Mon, Jun 23, 2014 at 11:44 AM, Ben Pfaff wrote: > > On Fri, Jun 13, 2014 at 07:40:01AM -0700, Gurucharan Shetty wrote: > >> After the change, both of them compile. test-netflow related > >> unit tests pass. > >> > >> test-sflo

Re: [ovs-dev] [PATCH v2 2/7] tests: Port test-sflow and test-netflow to windows.

2014-06-27 Thread Gurucharan Shetty
On Mon, Jun 23, 2014 at 11:44 AM, Ben Pfaff wrote: > On Fri, Jun 13, 2014 at 07:40:01AM -0700, Gurucharan Shetty wrote: >> After the change, both of them compile. test-netflow related >> unit tests pass. >> >> test-sflow related tests do not pass because >> of LOOPBACK_INTERFACE constraints for 'a

Re: [ovs-dev] [PATCH v2 2/7] tests: Port test-sflow and test-netflow to windows.

2014-06-24 Thread Gurucharan Shetty
> > This patch kind of stands out to me when I look at it. It is awkward > to have to create an extra object (wevent) on Windows but not use it > anywhere except to pass to poll_fd_wait_event(). I didn't properly > understand until now that this was necessary. > > Looking through the tree, I thin

Re: [ovs-dev] [PATCH v2 2/7] tests: Port test-sflow and test-netflow to windows.

2014-06-23 Thread Ben Pfaff
On Fri, Jun 13, 2014 at 07:40:01AM -0700, Gurucharan Shetty wrote: > After the change, both of them compile. test-netflow related > unit tests pass. > > test-sflow related tests do not pass because > of LOOPBACK_INTERFACE constraints for 'agent'. > (It should be revisited later.) > > Signed-off-b

[ovs-dev] [PATCH v2 2/7] tests: Port test-sflow and test-netflow to windows.

2014-06-13 Thread Gurucharan Shetty
After the change, both of them compile. test-netflow related unit tests pass. test-sflow related tests do not pass because of LOOPBACK_INTERFACE constraints for 'agent'. (It should be revisited later.) Signed-off-by: Gurucharan Shetty --- v1-v2: Remove the call to winsock_start() as WSAStartup