Re: [ovs-dev] [PATCH v2 2/2] ofproto: Allow in-place modifications of datapath flows.

2015-08-11 Thread Joe Stringer
On 11 August 2015 at 11:13, Jarno Rajahalme wrote: >> -if (!keep) { >> +if (result == UKEY_DELETE) { >> delete_op_init(udpif, &ops[n_ops++], ukey); >> +} else if (result == UKEY_MODIFY) { >> +ofpbuf_delete(ukey->actions); >> +

Re: [ovs-dev] [PATCH v2 2/2] ofproto: Allow in-place modifications of datapath flows.

2015-08-11 Thread Joe Stringer
On 10 August 2015 at 18:46, Ethan J. Jackson wrote: > exit: > -if (ok) { > +if (result != UKEY_DELETE) { > ukey->reval_seq = reval_seq; > } > -if (netflow && !ok) { > +if (netflow && result != UKEY_DELETE) { > netflow_flow_clear(netflow, &flow); > } I

Re: [ovs-dev] [PATCH v2 2/2] ofproto: Allow in-place modifications of datapath flows.

2015-08-11 Thread Jarno Rajahalme
> On Aug 10, 2015, at 6:46 PM, Ethan J. Jackson wrote: > > From: Ethan Jackson > > There are certain use cases (such as bond rebalancing) where a > datapath flow's actions may change, while it's wildcard pattern > remains the same. Before this patch, revalidators would note the > change, dele

[ovs-dev] [PATCH v2 2/2] ofproto: Allow in-place modifications of datapath flows.

2015-08-10 Thread Ethan J. Jackson
From: Ethan Jackson There are certain use cases (such as bond rebalancing) where a datapath flow's actions may change, while it's wildcard pattern remains the same. Before this patch, revalidators would note the change, delete the flow, and wait for the handlers to install an updated version. T