Re: [ovs-dev] [PATCH v2 2/2] datapath: Simplify vport_send() error handling.

2014-12-23 Thread Jesse Gross
On Tue, Dec 23, 2014 at 7:53 PM, Pravin Shelar wrote: > On Mon, Dec 22, 2014 at 8:32 PM, Jesse Gross wrote: >> On Mon, Dec 22, 2014 at 6:24 PM, Pravin B Shelar wrote: >>> Today vport-send has complex error handling because it involves >>> freeing skb and updating stats depending on return value

Re: [ovs-dev] [PATCH v2 2/2] datapath: Simplify vport_send() error handling.

2014-12-23 Thread Pravin Shelar
On Mon, Dec 22, 2014 at 8:32 PM, Jesse Gross wrote: > On Mon, Dec 22, 2014 at 6:24 PM, Pravin B Shelar wrote: >> Today vport-send has complex error handling because it involves >> freeing skb and updating stats depending on return value from >> vport send implementation. >> This can be simplified

Re: [ovs-dev] [PATCH v2 2/2] datapath: Simplify vport_send() error handling.

2014-12-22 Thread Jesse Gross
On Mon, Dec 22, 2014 at 6:24 PM, Pravin B Shelar wrote: > Today vport-send has complex error handling because it involves > freeing skb and updating stats depending on return value from > vport send implementation. > This can be simplified by delegating responsibility of freeing > skb to the vport

[ovs-dev] [PATCH v2 2/2] datapath: Simplify vport_send() error handling.

2014-12-22 Thread Pravin B Shelar
Today vport-send has complex error handling because it involves freeing skb and updating stats depending on return value from vport send implementation. This can be simplified by delegating responsibility of freeing skb to the vport implementation for all cases. So that vport-send needs just update