Re: [ovs-dev] [PATCH v2 16/19] ovs-ofctl: Add 'bundle' command and unit testing.

2015-06-05 Thread Ben Pfaff
On Fri, Jun 05, 2015 at 12:55:41PM -0700, Jarno Rajahalme wrote: > > > On May 29, 2015, at 8:58 PM, Ben Pfaff wrote: > > I'm a little surprised to see the new "error_reporter" callback > > function. Can you explain a little? > > Within a bundle we are now streaming the flow mods without waiting

Re: [ovs-dev] [PATCH v2 16/19] ovs-ofctl: Add 'bundle' command and unit testing.

2015-06-05 Thread Jarno Rajahalme
> On Jun 5, 2015, at 12:55 PM, Jarno Rajahalme wrote: > >> This will be really nice, thanks for implementing it. >> >> (Now, to find out why there are three more commits...) > > > Will post a v3 with the rest of the series soon. v3 posted! Have a nice weekend, Jarno

Re: [ovs-dev] [PATCH v2 16/19] ovs-ofctl: Add 'bundle' command and unit testing.

2015-06-05 Thread Jarno Rajahalme
> On May 29, 2015, at 8:58 PM, Ben Pfaff wrote: > > On Mon, May 18, 2015 at 04:10:25PM -0700, Jarno Rajahalme wrote: >> The new ovs-ofctl 'bundle' command accepts files similar to >> 'add-flows', but each line can optionally start with 'add', 'modify', >> 'delete', 'modify_strict', or 'delete_st

Re: [ovs-dev] [PATCH v2 16/19] ovs-ofctl: Add 'bundle' command and unit testing.

2015-06-05 Thread Jarno Rajahalme
Thanks for the suggestons, all applied in the v3 series I’ll post soon. Jarno > On May 20, 2015, at 11:26 AM, Romain Lenglet > wrote: > > Jarno, > Thanks a lot for this updated patch, this will be very useful. > Sorry, I don’t feel comfortable reviewing the other patches. > > Acked-by: Roma

Re: [ovs-dev] [PATCH v2 16/19] ovs-ofctl: Add 'bundle' command and unit testing.

2015-05-29 Thread Ben Pfaff
On Mon, May 18, 2015 at 04:10:25PM -0700, Jarno Rajahalme wrote: > The new ovs-ofctl 'bundle' command accepts files similar to > 'add-flows', but each line can optionally start with 'add', 'modify', > 'delete', 'modify_strict', or 'delete_strict' keyword, so that > arbitrary flow table modification

Re: [ovs-dev] [PATCH v2 16/19] ovs-ofctl: Add 'bundle' command and unit testing.

2015-05-20 Thread Jarno Rajahalme
Romain, Thanks for the review! I hope Ben finds time for reviewing the rest of the series sometime later. Jarno > On May 20, 2015, at 11:26 AM, Romain Lenglet > wrote: > > Jarno, > Thanks a lot for this updated patch, this will be very useful. > Sorry, I don’t feel comfortable reviewing th

Re: [ovs-dev] [PATCH v2 16/19] ovs-ofctl: Add 'bundle' command and unit testing.

2015-05-20 Thread Romain Lenglet
Jarno, Thanks a lot for this updated patch, this will be very useful. Sorry, I don’t feel comfortable reviewing the other patches. Acked-by: Romain Lenglet -- Romain Lenglet On May 18, 2015 at 4:26:12 PM, Jarno Rajahalme (jrajaha...@nicira.com(mailto:jrajaha...@nicira.com)) wrote: > The ne

[ovs-dev] [PATCH v2 16/19] ovs-ofctl: Add 'bundle' command and unit testing.

2015-05-18 Thread Jarno Rajahalme
The new ovs-ofctl 'bundle' command accepts files similar to 'add-flows', but each line can optionally start with 'add', 'modify', 'delete', 'modify_strict', or 'delete_strict' keyword, so that arbitrary flow table modifications may be specified in a single file. The modifications in the file are ex