Re: [ovs-dev] [PATCH v2 11/19] ofproto: Refactor modify_flows__().

2015-06-01 Thread Jarno Rajahalme
> On May 29, 2015, at 6:01 PM, Ben Pfaff wrote: > > On Mon, May 18, 2015 at 04:10:20PM -0700, Jarno Rajahalme wrote: >> Signed-off-by: Jarno Rajahalme > > I see some opportunity for simplification in modify_flows_check__(): > > diff --git a/ofproto/ofproto.c b/ofproto/ofproto.c > index 5c8b1a

Re: [ovs-dev] [PATCH v2 11/19] ofproto: Refactor modify_flows__().

2015-05-29 Thread Ben Pfaff
On Mon, May 18, 2015 at 04:10:20PM -0700, Jarno Rajahalme wrote: > Signed-off-by: Jarno Rajahalme I see some opportunity for simplification in modify_flows_check__(): diff --git a/ofproto/ofproto.c b/ofproto/ofproto.c index 5c8b1a5..cb53245 100644 --- a/ofproto/ofproto.c +++ b/ofproto/ofproto.c

[ovs-dev] [PATCH v2 11/19] ofproto: Refactor modify_flows__().

2015-05-18 Thread Jarno Rajahalme
Signed-off-by: Jarno Rajahalme --- ofproto/ofproto.c | 317 +++-- 1 file changed, 187 insertions(+), 130 deletions(-) diff --git a/ofproto/ofproto.c b/ofproto/ofproto.c index 6a8239e..5c8b1a5 100644 --- a/ofproto/ofproto.c +++ b/ofproto/ofproto.c