Re: [ovs-dev] [PATCH v2 10/19] ofproto: Use enum ofperr for 'error'.

2015-06-01 Thread Jarno Rajahalme
> On May 29, 2015, at 5:54 PM, Ben Pfaff wrote: > > On Mon, May 18, 2015 at 04:10:19PM -0700, Jarno Rajahalme wrote: >> Signed-off-by: Jarno Rajahalme > > Hmm, ofproto_rule_create() returns ENOMEM instead of an ofperr on error, > we should fix that. > > I see a few references to OFPROTO_POSTP

Re: [ovs-dev] [PATCH v2 10/19] ofproto: Use enum ofperr for 'error'.

2015-05-29 Thread Ben Pfaff
On Mon, May 18, 2015 at 04:10:19PM -0700, Jarno Rajahalme wrote: > Signed-off-by: Jarno Rajahalme Hmm, ofproto_rule_create() returns ENOMEM instead of an ofperr on error, we should fix that. I see a few references to OFPROTO_POSTPONE in function comments too, we should drop those since we no lon

[ovs-dev] [PATCH v2 10/19] ofproto: Use enum ofperr for 'error'.

2015-05-18 Thread Jarno Rajahalme
Signed-off-by: Jarno Rajahalme --- ofproto/ofproto.c | 12 ++-- 1 file changed, 6 insertions(+), 6 deletions(-) diff --git a/ofproto/ofproto.c b/ofproto/ofproto.c index d0124e0..6a8239e 100644 --- a/ofproto/ofproto.c +++ b/ofproto/ofproto.c @@ -3866,7 +3866,7 @@ collect_rules_strict(st