Thanks for the review!
Pushed with the change that classifier_remove takes a const struct cls_rule
pointer as an argument.
Jarno
On Nov 6, 2014, at 11:58 AM, Ben Pfaff wrote:
> On Thu, Nov 06, 2014 at 11:29:26AM -0800, Jarno Rajahalme wrote:
>>
>> On Nov 6, 2014, at 11:08 AM, Ben Pfaff wr
On Thu, Nov 06, 2014 at 11:29:26AM -0800, Jarno Rajahalme wrote:
>
> On Nov 6, 2014, at 11:08 AM, Ben Pfaff wrote:
>
> > On Thu, Nov 06, 2014 at 11:06:59AM -0800, Ben Pfaff wrote:
> >> On Thu, Nov 06, 2014 at 11:02:56AM -0800, Ben Pfaff wrote:
> >>> On Mon, Nov 03, 2014 at 11:39:00AM -0800, Jarn
On Nov 6, 2014, at 11:08 AM, Ben Pfaff wrote:
> On Thu, Nov 06, 2014 at 11:06:59AM -0800, Ben Pfaff wrote:
>> On Thu, Nov 06, 2014 at 11:02:56AM -0800, Ben Pfaff wrote:
>>> On Mon, Nov 03, 2014 at 11:39:00AM -0800, Jarno Rajahalme wrote:
Returning const struct cls_rule pointers from the cla
On Thu, Nov 06, 2014 at 11:06:59AM -0800, Ben Pfaff wrote:
> On Thu, Nov 06, 2014 at 11:02:56AM -0800, Ben Pfaff wrote:
> > On Mon, Nov 03, 2014 at 11:39:00AM -0800, Jarno Rajahalme wrote:
> > > Returning const struct cls_rule pointers from the classifier API helps
> > > callers to remember that th
On Thu, Nov 06, 2014 at 11:02:56AM -0800, Ben Pfaff wrote:
> On Mon, Nov 03, 2014 at 11:39:00AM -0800, Jarno Rajahalme wrote:
> > Returning const struct cls_rule pointers from the classifier API helps
> > callers to remember that they should not modify the rules returned.
> >
> > Signed-off-by: Ja
On Mon, Nov 03, 2014 at 11:39:00AM -0800, Jarno Rajahalme wrote:
> Returning const struct cls_rule pointers from the classifier API helps
> callers to remember that they should not modify the rules returned.
>
> Signed-off-by: Jarno Rajahalme
I don't think it has much practical effect since most
Returning const struct cls_rule pointers from the classifier API helps
callers to remember that they should not modify the rules returned.
Signed-off-by: Jarno Rajahalme
---
lib/classifier.c| 103 ++-
lib/classifier.h| 25 ++-
