On Tue, May 13, 2014 at 01:42:47PM -0700, Jesse Gross wrote:
> On Mon, May 12, 2014 at 10:46 PM, Simon Horman wrote:
> > On Mon, May 12, 2014 at 04:32:29PM -0700, Daniele Di Proietto wrote:
> >> You’re right, of course.
> >>
> >> Sorry I didn’t see it the first time.
> >>
> >> On May 12, 2014, at
On Mon, May 12, 2014 at 10:46 PM, Simon Horman wrote:
> On Mon, May 12, 2014 at 04:32:29PM -0700, Daniele Di Proietto wrote:
>> You’re right, of course.
>>
>> Sorry I didn’t see it the first time.
>>
>> On May 12, 2014, at 4:28 PM, Jesse Gross wrote:
>>
>> > On Mon, May 12, 2014 at 4:06 PM, Danie
On Mon, May 12, 2014 at 04:32:29PM -0700, Daniele Di Proietto wrote:
> You’re right, of course.
>
> Sorry I didn’t see it the first time.
>
> On May 12, 2014, at 4:28 PM, Jesse Gross wrote:
>
> > On Mon, May 12, 2014 at 4:06 PM, Daniele Di Proietto
> > wrote:
> >> If I understand correctly, th
You’re right, of course.
Sorry I didn’t see it the first time.
On May 12, 2014, at 4:28 PM, Jesse Gross wrote:
> On Mon, May 12, 2014 at 4:06 PM, Daniele Di Proietto
> wrote:
>> If I understand correctly, the new code frees the skb only if
>> execute_recirc() _returns_ an error and this can h
On Mon, May 12, 2014 at 4:06 PM, Daniele Di Proietto
wrote:
> If I understand correctly, the new code frees the skb only if
> execute_recirc() _returns_ an error and this can happen only if
> ovs_flow_extract() returns an error, in which case recirc_skb only gets freed
> once, but maybe I’m wro
If I understand correctly, the new code frees the skb only if execute_recirc()
_returns_ an error and this can happen only if ovs_flow_extract() returns an
error, in which case recirc_skb only gets freed once, but maybe I’m wrong.
I agree that it probably makes sense to have execute_recirc() tak
On Sat, May 10, 2014 at 7:46 PM, Simon Horman wrote:
> It is my understanding that on error execute_recirc() does not free the
> skb passed to it.
>
> Assuming this is true then on error skb should always be freed
> if an error occurs in execute_recirc().
>
> And if recirc_skb differs from skb, be
Acked-by: Daniele Di Proietto
On May 10, 2014, at 7:46 PM, Simon Horman wrote:
> Signed-off-by: Simon Horman
___
dev mailing list
dev@openvswitch.org
http://openvswitch.org/mailman/listinfo/dev
It is my understanding that on error execute_recirc() does not free the
skb passed to it.
Assuming this is true then on error skb should always be freed
if an error occurs in execute_recirc().
And if recirc_skb differs from skb, because it is a clone of skb,
then it should also be freed.
Signed-
