Re: [ovs-dev] [PATCH v2 03/13] datapath: Fix race.

2014-02-13 Thread Jarno Rajahalme
Thanks for the review. Pushed to master, 2.1, 2.0, 1.11, 1.10, and 1.9, Jarno On Feb 12, 2014, at 3:35 PM, Pravin Shelar wrote: > On Tue, Feb 11, 2014 at 4:07 PM, Jarno Rajahalme > wrote: >> ovs_vport_cmd_dump() did rcu_read_lock() only after getting the >> datapath, which could have been

Re: [ovs-dev] [PATCH v2 03/13] datapath: Fix race.

2014-02-12 Thread Pravin Shelar
On Tue, Feb 11, 2014 at 4:07 PM, Jarno Rajahalme wrote: > ovs_vport_cmd_dump() did rcu_read_lock() only after getting the > datapath, which could have been deleted in between. Resolved by > taking rcu_read_lock() before the get_dp() call. > > Signed-off-by: Jarno Rajahalme Looks good. Acked-by:

[ovs-dev] [PATCH v2 03/13] datapath: Fix race.

2014-02-11 Thread Jarno Rajahalme
ovs_vport_cmd_dump() did rcu_read_lock() only after getting the datapath, which could have been deleted in between. Resolved by taking rcu_read_lock() before the get_dp() call. Signed-off-by: Jarno Rajahalme --- v2: No change datapath/datapath.c |7 --- 1 file changed, 4 insertions(+),