Re: [ovs-dev] [PATCH v2 00/11] instruction apply-actions/goto-table support

2012-07-23 Thread Isaku Yamahata
On Sun, Jul 22, 2012 at 09:35:39PM -0700, Ben Pfaff wrote: > > What concerns me is how complex xlate_actions() would be with Write-Actions. > > Anyway we can re-consider it when I (or someone else) attack Write-Actions. > > It is internal representation, not exposed API/ABI. > > I had the idea tha

Re: [ovs-dev] [PATCH v2 00/11] instruction apply-actions/goto-table support

2012-07-22 Thread Ben Pfaff
On Mon, Jul 23, 2012 at 11:30:21AM +0900, Isaku Yamahata wrote: > On Thu, Jul 19, 2012 at 08:53:23PM -0700, Ben Pfaff wrote: > > On Fri, Jul 20, 2012 at 11:23:02AM +0900, Isaku Yamahata wrote: > > > This patch adds instruction OF11 apply-actions/goto-table supports. > > > > > > I rewrite the patch

Re: [ovs-dev] [PATCH v2 00/11] instruction apply-actions/goto-table support

2012-07-22 Thread Isaku Yamahata
On Thu, Jul 19, 2012 at 08:53:23PM -0700, Ben Pfaff wrote: > On Fri, Jul 20, 2012 at 11:23:02AM +0900, Isaku Yamahata wrote: > > This patch adds instruction OF11 apply-actions/goto-table supports. > > > > I rewrite the patch series based on Ben's suggestion. > > Now introduce ofpact_instruction to

Re: [ovs-dev] [PATCH v2 00/11] instruction apply-actions/goto-table support

2012-07-22 Thread Joe Stringer
On 21 July 2012 18:25, Ben Pfaff wrote: ... > That's right except that actions and instructions overlap, so there's > not the clear-cut difference that you're envisioning. Thanks for pointing this out. Given the current implementation only supports apply-actions, I had associated OpenFlow 1.0 act

Re: [ovs-dev] [PATCH v2 00/11] instruction apply-actions/goto-table support

2012-07-20 Thread Ben Pfaff
On Fri, Jul 20, 2012 at 11:39:21PM +1200, Joe Stringer wrote: > On 20 July 2012 15:53, Ben Pfaff wrote: > ... > > For the string representations, as I told Joe Stringer, I'm leaning > > toward requiring them to be in the correct order for instructions listed > > above. Otherwise it seems risky th

Re: [ovs-dev] [PATCH v2 00/11] instruction apply-actions/goto-table support

2012-07-20 Thread Joe Stringer
On 20 July 2012 15:53, Ben Pfaff wrote: ... > For the string representations, as I told Joe Stringer, I'm leaning > toward requiring them to be in the correct order for instructions listed > above. Otherwise it seems risky that one could confuse the user. > Similarly for the OF1.0 extension repre

Re: [ovs-dev] [PATCH v2 00/11] instruction apply-actions/goto-table support

2012-07-19 Thread Ben Pfaff
On Fri, Jul 20, 2012 at 11:23:02AM +0900, Isaku Yamahata wrote: > This patch adds instruction OF11 apply-actions/goto-table supports. > > I rewrite the patch series based on Ben's suggestion. > Now introduce ofpact_instruction to represent instruction delimiter, > and avoid nesting. > Ben, do you

[ovs-dev] [PATCH v2 00/11] instruction apply-actions/goto-table support

2012-07-19 Thread Isaku Yamahata
This patch adds instruction OF11 apply-actions/goto-table supports. I rewrite the patch series based on Ben's suggestion. Now introduce ofpact_instruction to represent instruction delimiter, and avoid nesting. Ben, do you like this approach? I did only compile-tested for now. If this approach is o