Re: [ovs-dev] [PATCH v2] xlate: Use dp_hash for select groups.

2016-09-16 Thread Jarno Rajahalme
No, thank you for remembering to prompt for the documentation, I would not have noticed the bug otherwise! v3 pushed to master, Jarno > On Sep 15, 2016, at 7:26 PM, Ben Pfaff wrote: > > OK. Thanks for being so careful! > > I'll look at v3. > > On Thu, Sep 15, 2016 at 06:43:39PM -0700, Ja

Re: [ovs-dev] [PATCH v2] xlate: Use dp_hash for select groups.

2016-09-15 Thread Ben Pfaff
OK. Thanks for being so careful! I'll look at v3. On Thu, Sep 15, 2016 at 06:43:39PM -0700, Jarno Rajahalme wrote: > Thanks for the fix! > > While I was working with tightening the parsing, I found that I had earlier > introduced a bug that crashes ovs-ofctl when a parsing error is found after

Re: [ovs-dev] [PATCH v2] xlate: Use dp_hash for select groups.

2016-09-15 Thread Jarno Rajahalme
Thanks for the fix! While I was working with tightening the parsing, I found that I had earlier introduced a bug that crashes ovs-ofctl when a parsing error is found after parsing ‘fields’, essentially a double free. I sent a v3 fixing this, documenting the parsing tightening and then rebasing

Re: [ovs-dev] [PATCH v2] xlate: Use dp_hash for select groups.

2016-09-14 Thread Ben Pfaff
On Wed, Sep 14, 2016 at 08:51:42PM -0700, Ben Pfaff wrote: > On Mon, Sep 12, 2016 at 04:16:08PM -0700, Jarno Rajahalme wrote: > > Add a new select group selection method "dp_hash", which uses minimal > > number of bits from the datapath calculated packet hash to inform the > > select group bucket s

Re: [ovs-dev] [PATCH v2] xlate: Use dp_hash for select groups.

2016-09-14 Thread Ben Pfaff
On Mon, Sep 12, 2016 at 04:16:08PM -0700, Jarno Rajahalme wrote: > Add a new select group selection method "dp_hash", which uses minimal > number of bits from the datapath calculated packet hash to inform the > select group bucket selection. This makes the datapath flows more > generic resulting i

[ovs-dev] [PATCH v2] xlate: Use dp_hash for select groups.

2016-09-12 Thread Jarno Rajahalme
Add a new select group selection method "dp_hash", which uses minimal number of bits from the datapath calculated packet hash to inform the select group bucket selection. This makes the datapath flows more generic resulting in less upcalls to userspace, but adds recirculation prior to group select